Task #92619
closed
Epic #89595: Improve accessibility of backend
Login button has an invalid attribute
100%
Description
The login button contains the attribute "autocomplete" which is not allowed with <button>. #tas2020 TYPO3-8
Updated by Gerrit Code Review about 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66317
Updated by Gerrit Code Review about 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66335
Updated by Mark Leutl about 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e6bd4f02ad77de5881c8c0ab1fe47fa4a004f2ff.
Updated by Christian Kuhn about 4 years ago
Patch has been merged to master and will be reverted there again because firefox acts funny. Requested 10.4 backport has not been merged.
Updated by Jonas Eberle about 4 years ago
What were the problems with Firefox like?
Updated by Martin Kutschker about 4 years ago
What are the issues? I have tried the patch and had no issues.
Updated by Michael Telgkamp about 4 years ago
- Status changed from Resolved to On Hold
As stated in the master merge request there is currently a bug with Firefox. The disabled state of a button might be persisted - see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-autocomplete and the bug at https://bugzilla.mozilla.org/show_bug.cgi?id=654072
Without the additional autocomplete attribute it can happen, that there is a disabled button on the login page, although it should be active. This can break the login completely.
While the Firefox bug is still open, the patch for this bug should not be merged.
Updated by Martin Kutschker about 4 years ago
Incredibly stupid and long standing FF bug. Funny I have never (as FF user) seen it in the wild.
Anyways, I'm not in the camp who removes attributes that are marked as wrong by a validator just because.
Thanks for the clarification.
Updated by Riccardo De Contardi 8 months ago
Firefox issue seems still unresolved :O
Updated by Garvin Hicking 5 months ago
- Status changed from On Hold to Closed
Since FF may not probably adress this legacy bug of theirs anytime soon, and the backend itself factually works with the attribute in supported browsers, I would like to close this issue for the time being, to clean up our issues a bit. I hope you can understand and agree. If you believe this is a mistake, please get in touch and we'll check.