Actions
Bug #92699
closed
variables in ContentObjectRenderer::checkIf
Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2020-10-24
Due date:
% Done:
0%
Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
ContentObjectRenderer rendering TypoScript
Complexity:
no-brainer
Is Regression:
Sprint Focus:
Description
Some variable are not checked properly before usage:
For many variables is checked this:
if (isset($conf['a']) || isset($conf['a.'])) {
but used are both.
Concrete example:
if (isset($conf['isTrue']) || isset($conf['isTrue.'])) {
$isTrue = isset($conf['isTrue.']) ? trim($this->stdWrap($conf['isTrue'], $conf['isTrue.'])) : trim($conf['isTrue']);
if (!$isTrue) {
$flag = false;
}
}
This example is throwing an error if $conf['isTrue.'] is set but $conf['isTrue'] not.
Updated by David Bruchmann about 4 years ago
Data to test:
config.pageTitle.stdWrap.override.cObject = CONTENT
config.pageTitle.stdWrap.override.cObject {
table = tt_content
select {
where = colPos=0
# pidInList = this
# uidInList = this
orderBy = sorting
selectFields = header
max = 1
}
# slide = 0
# slide {
# collect = 0
# collectReverse = 0
# collectFuzzy = 0
# }
renderObj = TEXT
renderObj.value.field = header
# if.isFalse = 0
if.isFalse = field : seo_title
}
Commented lines were added to make the TypoScript passing the hurdles in the code.
Updated by Benni Mack over 2 years ago
- Complexity set to no-brainer
- Sprint Focus set to Remote Sprint
Updated by Susanne Moog over 2 years ago
- Sprint Focus changed from Remote Sprint to On Location Sprint
Updated by Oliver Hader about 2 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Georg Ringer 6 months ago
- Status changed from New to Closed
code changed to $this->stdWrapValue which checks everything correctly. closing issue
Updated by David Bruchmann 6 months ago
I can confirm, the issue is fixed since already long time.
Actions