Project

General

Profile

Actions

Bug #92983

closed

Header formatting in scheduler for Console Commands

Added by Tomas Norre Mikkelsen almost 4 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
scheduler
Start date:
2020-12-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When using symfony Console commands in the backend, there are some issues with the formatting.

When choosing the "Execute Console Commands" and scroll down to the selection field. I see following

Schedulable Command. <em>Save and reopen to define command arguments</em>

The "em" is not parsed.


Files

Screenshot from 2020-12-04 05_32_58.png (7.18 KB) Screenshot from 2020-12-04 05_32_58.png Tomas Norre Mikkelsen, 2020-12-04 04:38

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #92964: Headers are shown with HTML tags in scheduler taskClosed2020-12-01

Actions
Related to TYPO3 Core - Bug #102317: Special characters are encoded in scheduled tasks as HTML entitiesClosed2023-11-05

Actions
Actions #1

Updated by Tomas Norre Mikkelsen almost 4 years ago

It's coming from this and the following functions as I see it.
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php#L335


/**
     * Get a human-readable label for a command argument
     *
     * @param InputArgument $argument
     * @return string
     */
    protected function getArgumentLabel(InputArgument $argument): string
    {
        return 'Argument: ' . $argument->getName() . '. <em>' . htmlspecialchars($argument->getDescription()) . '</em>';
    }

    /**
     * Get a human-readable label for a command option
     *
     * @param InputOption $option
     * @return string
     */
    protected function getOptionLabel(InputOption $option): string
    {
        return 'Option: ' . htmlspecialchars($option->getName()) . '. <em>' . htmlspecialchars($option->getDescription()) . '</em>';
    }

Actions #2

Updated by Tomas Norre Mikkelsen almost 4 years ago

I have tried to use the format viewhelper in the EditTask.html to have it parsed correct. But no success.

Actions #3

Updated by Tomas Norre Mikkelsen almost 4 years ago

This is a "regression" from:

https://review.typo3.org/c/Packages/TYPO3.CMS/+/66663
https://github.com/TYPO3/TYPO3.CMS/commit/6a972407b5d025322901d89d9f0318d69f2c29c8

The Security fix is of course more important, so not sure if regression is the right word, it's at least introduced as a consequence of this update.

Actions #4

Updated by Oliver Bartsch almost 4 years ago

  • Related to Bug #92964: Headers are shown with HTML tags in scheduler task added
Actions #5

Updated by Tomas Norre Mikkelsen almost 4 years ago

I don't think they are only related, I think there are the "same" issue.

Actions #6

Updated by Sybille Peters almost 4 years ago

Seems to be a general problem.

Actions #7

Updated by Eric Chavaillaz almost 4 years ago

I can confirm this bug.

It comes from a double encoding in the "typo3/sysext/fluid/Classes/ViewHelpers/Be/Labels/CshViewHelper.php":

// Double encode can be set to true, once the typo3fluid/fluid fix is released and required
$label = '<label>' . htmlspecialchars($label, ENT_QUOTES, null, false) . '</label>';

Eric

Actions #8

Updated by Georg Ringer almost 4 years ago

  • Status changed from New to Closed

I close that as duplicate of #92964

Actions #9

Updated by Sybille Peters almost 4 years ago

  • Status changed from Closed to New
Actions #10

Updated by Sybille Peters almost 4 years ago

Still open. #92964 was fixed.

Actions #11

Updated by Georg Ringer almost 4 years ago

  • Status changed from New to Accepted
Actions #12

Updated by Benni Mack 11 months ago

  • Related to Bug #102317: Special characters are encoded in scheduled tasks as HTML entities added
Actions #13

Updated by Benni Mack 11 months ago

  • Status changed from Accepted to Needs Feedback

I do think this is fixed with #102317 - can you verify this?

Actions #14

Updated by Riccardo De Contardi 11 months ago

I am not able to reproduce it on version 13 (latest main)

Moreover the lines reported on comment 1 are not present anymore if I am not wrong

About comment 7, am I totally wrong or CSH has been removed on version 12? https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-97312-RemoveContextSensitiveHelp.html

Actions #15

Updated by Georg Ringer 6 months ago

  • Status changed from Needs Feedback to Closed

closing issue because of lack of feedback.
if still valid, feel free to reopen a new issue and set this one as related!

thanks!

Actions

Also available in: Atom PDF