Bug #92983
closedHeader formatting in scheduler for Console Commands
0%
Description
When using symfony Console commands in the backend, there are some issues with the formatting.
When choosing the "Execute Console Commands" and scroll down to the selection field. I see following
Schedulable Command. <em>Save and reopen to define command arguments</em>
The "em" is not parsed.
Files
Updated by Tomas Norre Mikkelsen almost 4 years ago
It's coming from this and the following functions as I see it.
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php#L335
/**
* Get a human-readable label for a command argument
*
* @param InputArgument $argument
* @return string
*/
protected function getArgumentLabel(InputArgument $argument): string
{
return 'Argument: ' . $argument->getName() . '. <em>' . htmlspecialchars($argument->getDescription()) . '</em>';
}
/**
* Get a human-readable label for a command option
*
* @param InputOption $option
* @return string
*/
protected function getOptionLabel(InputOption $option): string
{
return 'Option: ' . htmlspecialchars($option->getName()) . '. <em>' . htmlspecialchars($option->getDescription()) . '</em>';
}
Updated by Tomas Norre Mikkelsen almost 4 years ago
I have tried to use the format viewhelper in the EditTask.html to have it parsed correct. But no success.
Updated by Tomas Norre Mikkelsen almost 4 years ago
This is a "regression" from:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/66663
https://github.com/TYPO3/TYPO3.CMS/commit/6a972407b5d025322901d89d9f0318d69f2c29c8
The Security fix is of course more important, so not sure if regression is the right word, it's at least introduced as a consequence of this update.
Updated by Oliver Bartsch almost 4 years ago
- Related to Bug #92964: Headers are shown with HTML tags in scheduler task added
Updated by Tomas Norre Mikkelsen almost 4 years ago
I don't think they are only related, I think there are the "same" issue.
Updated by Eric Chavaillaz almost 4 years ago
I can confirm this bug.
It comes from a double encoding in the "typo3/sysext/fluid/Classes/ViewHelpers/Be/Labels/CshViewHelper.php":
// Double encode can be set to true, once the typo3fluid/fluid fix is released and required $label = '<label>' . htmlspecialchars($label, ENT_QUOTES, null, false) . '</label>';
Eric
Updated by Georg Ringer almost 4 years ago
- Status changed from New to Closed
I close that as duplicate of #92964
Updated by Benni Mack 11 months ago
- Related to Bug #102317: Special characters are encoded in scheduled tasks as HTML entities added
Updated by Benni Mack 11 months ago
- Status changed from Accepted to Needs Feedback
I do think this is fixed with #102317 - can you verify this?
Updated by Riccardo De Contardi 11 months ago
I am not able to reproduce it on version 13 (latest main)
Moreover the lines reported on comment 1 are not present anymore if I am not wrong
About comment 7, am I totally wrong or CSH has been removed on version 12? https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-97312-RemoveContextSensitiveHelp.html
Updated by Georg Ringer 6 months ago
- Status changed from Needs Feedback to Closed
closing issue because of lack of feedback.
if still valid, feel free to reopen a new issue and set this one as related!
thanks!