Project

General

Profile

Actions

Bug #93370

open

Redirects: non-admin users can not revert redirects via popup (although BE notification claims otherwise)

Added by Sebastian Peine over 3 years ago. Updated 6 months ago.

Status:
Needs Feedback
Priority:
Must have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2021-01-26
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Scenario (TYPO3 Version 10.4.12):
A non-admin user changes the slug of a page, saves the page, the popup appears to revert the change or revert the redirect only.
Click on revert, then the notification "Revert successful - All created redirects have been reverted." appears. But the redirect still exists and is not removed.

This is what I found debugging this behaviour:
in \TYPO3\CMS\Redirects\Controller\RecordHistoryRollbackController::rollBackCorrelation a Changelog of the sys_redirect record is retrieved.
But as all redirects are stored in PID 0, the check for pageAccess in \TYPO3\CMS\Backend\History\RecordHistory::getHistoryDataForRecord (l. 367, $this->hasPageAccess) fails, so an empty changelog is returned and a "false positive" notification is shown that all redirects are reverted.
($id passed to \TYPO3\CMS\Backend\Utility\BackendUtility::readPageAccess is 0, so it returns false for all non-admins).


Related issues 1 (1 open0 closed)

Related to TYPO3 Core - Task #89301: Streamline automatic slug & redirects handlingAccepted2019-09-29

Actions
Actions

Also available in: Atom PDF