Project

General

Profile

Actions

Bug #93887

open

Ext:Form Caching Determination breaking Ajax Request

Added by Heiko Fischer over 3 years ago. Updated 4 months ago.

Status:
Needs Feedback
Priority:
Should have
Category:
Form Framework
Target version:
-
Start date:
2021-04-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With Typo3 10.4.14 was a new method "isRenderedCached()" introduced in TYPO3\CMS\Form\Domain\Runtime. This method returns true on:

"$contentObject->getUserObjectType() === ContentObjectRenderer::OBJECTTYPE_USER"

We use an Ajax call for our Form Requests and the Extension helhum/typoscript_rendering for rendering a typoscript path. This extension uses a USER object. The above comparison statement determinates therefore our call as cached while it is not.

While this might be an issue with the helhum/typoscript_rendering extension and needs a change there, we find that comparison suspicious. Can anyone please explain why a USER object should always be cached?


Files

form_caching_tests.zip (24.3 KB) form_caching_tests.zip Ralf Zimmermann, 2021-08-12 19:00
Capto_Capture 2021-10-22_04-49-32_PM.mp4 (5.36 MB) Capto_Capture 2021-10-22_04-49-32_PM.mp4 see https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/26#message-94def7c7f7bfbe4ad9d2260f33be231dbb7bbbee Oliver Hader, 2021-10-22 15:31

Related issues 6 (2 open4 closed)

Related to TYPO3 Core - Feature #91419: Disable caching on a per form basisUnder Review2020-05-16

Actions
Related to TYPO3 Core - Bug #98222: Inconsistent form rendering after #93887Closed2022-08-29

Actions
Related to TYPO3 Core - Bug #98084: Honeypot not working anymore?New2022-08-05

Actions
Related to TYPO3 Core - Bug #98336: Revert modified cache handling in form frameworkClosed2022-09-12

Actions
Precedes TYPO3 Core - Bug #97977: New EXT:form request handling hides current ContentObjectRendererClosed2021-04-122021-04-12

Actions
Precedes TYPO3 Core - Bug #98023: custom prototypes cannot be appliedClosedRalf Zimmermann

Actions
Actions #1

Updated by Lukas Speck over 3 years ago

  • Project changed from 9 to TYPO3 Core
  • TYPO3 Version set to 10
Actions #2

Updated by Heiko Fischer over 3 years ago

  • Category set to Form Framework
Actions #3

Updated by Björn Jacob over 3 years ago

  • Sprint Focus set to Remote Sprint
Actions #5

Updated by Oliver Hader over 3 years ago

@RalfZimmermann was working on this during preparing the security fix, he has a better understanding of ext:form internal than I have.

https://review.typo3.org/c/Teams/Security/TYPO3v4-Core/+/66088/11..12/typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php#558 (security-internal link, just as reference)

Actions #6

Updated by Ralf Zimmermann over 3 years ago

  • Assignee set to Ralf Zimmermann
Actions #7

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #8

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #9

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #10

Updated by Ralf Zimmermann over 3 years ago

  • File form_caching_tests.zip added

The attached testing extension contains:

  • extbase plugins which render forms (cached / uncached)
  • typoscript to add FLUIDTEMPLATE objects at the end of the page (cached / uncached)
  • ext:form overwrites to see hidden security fields
Actions #11

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #12

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #13

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #14

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #15

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #16

Updated by Ralf Zimmermann over 3 years ago

  • File deleted (form_caching_tests.zip)
Actions #18

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #19

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #20

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #21

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #22

Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #23

Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #24

Updated by Gerrit Code Review over 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #25

Updated by Gerrit Code Review over 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #26

Updated by Björn Jacob over 3 years ago

  • Related to Feature #91419: Disable caching on a per form basis added
Actions #27

Updated by Gerrit Code Review over 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #28

Updated by Gerrit Code Review over 3 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #29

Updated by Gerrit Code Review over 3 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #30

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #31

Updated by Gerrit Code Review over 3 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #32

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #33

Updated by Gerrit Code Review over 3 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #34

Updated by Gerrit Code Review over 3 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #35

Updated by Gerrit Code Review over 3 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #36

Updated by Gerrit Code Review over 3 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #37

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #38

Updated by Gerrit Code Review over 3 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #39

Updated by Gerrit Code Review over 3 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #40

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #41

Updated by Gerrit Code Review over 3 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #42

Updated by Gerrit Code Review about 3 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #43

Updated by Gerrit Code Review about 3 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #44

Updated by Gerrit Code Review about 3 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #45

Updated by Oliver Hader about 3 years ago

  • File Capto_Capture 2021-10-22_04-49-32_PM.mov added
Actions #46

Updated by Oliver Hader about 3 years ago

  • File deleted (Capto_Capture 2021-10-22_04-49-32_PM.mov)
Actions #48

Updated by Gerrit Code Review almost 3 years ago

Patch set 27 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #49

Updated by Gerrit Code Review over 2 years ago

Patch set 28 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #50

Updated by Gerrit Code Review over 2 years ago

Patch set 29 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #51

Updated by Gerrit Code Review over 2 years ago

Patch set 30 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #52

Updated by Gerrit Code Review over 2 years ago

Patch set 31 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #53

Updated by Gerrit Code Review over 2 years ago

Patch set 32 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #54

Updated by Gerrit Code Review over 2 years ago

Patch set 33 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #55

Updated by Gerrit Code Review over 2 years ago

Patch set 34 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #56

Updated by Gerrit Code Review over 2 years ago

Patch set 35 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #57

Updated by Gerrit Code Review over 2 years ago

Patch set 36 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #58

Updated by Gerrit Code Review over 2 years ago

Patch set 37 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #59

Updated by Gerrit Code Review over 2 years ago

Patch set 38 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #60

Updated by Gerrit Code Review over 2 years ago

Patch set 39 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #61

Updated by Gerrit Code Review over 2 years ago

Patch set 40 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #62

Updated by Gerrit Code Review over 2 years ago

Patch set 41 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #63

Updated by Gerrit Code Review over 2 years ago

Patch set 42 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #64

Updated by Gerrit Code Review over 2 years ago

Patch set 43 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #65

Updated by Gerrit Code Review over 2 years ago

Patch set 44 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #66

Updated by Gerrit Code Review over 2 years ago

Patch set 45 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #67

Updated by Gerrit Code Review over 2 years ago

Patch set 46 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #68

Updated by Gerrit Code Review over 2 years ago

Patch set 47 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #69

Updated by Gerrit Code Review over 2 years ago

Patch set 48 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #70

Updated by Gerrit Code Review over 2 years ago

Patch set 49 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #71

Updated by Gerrit Code Review over 2 years ago

Patch set 50 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #72

Updated by Gerrit Code Review over 2 years ago

Patch set 51 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #73

Updated by Gerrit Code Review over 2 years ago

Patch set 52 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #74

Updated by Gerrit Code Review over 2 years ago

Patch set 53 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #75

Updated by Gerrit Code Review over 2 years ago

Patch set 54 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #76

Updated by Gerrit Code Review over 2 years ago

Patch set 55 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460

Actions #77

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013

Actions #78

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013

Actions #79

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013

Actions #80

Updated by Ralf Zimmermann over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #81

Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 4 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013

Actions #82

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013

Actions #83

Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013

Actions #84

Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013

Actions #85

Updated by Gerrit Code Review over 2 years ago

Patch set 8 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013

Actions #86

Updated by Gerrit Code Review over 2 years ago

Patch set 9 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013

Actions #87

Updated by Ralf Zimmermann over 2 years ago

  • Status changed from Under Review to Resolved
Actions #88

Updated by Oliver Hader over 2 years ago

  • Precedes Bug #97977: New EXT:form request handling hides current ContentObjectRenderer added
Actions #89

Updated by Oliver Hader over 2 years ago

  • Precedes Bug #98023: custom prototypes cannot be applied added
Actions #90

Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 9 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #91

Updated by Gerrit Code Review over 2 years ago

Patch set 10 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #92

Updated by Gerrit Code Review over 2 years ago

Patch set 11 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #93

Updated by Gerrit Code Review over 2 years ago

Patch set 12 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #94

Updated by Gerrit Code Review over 2 years ago

Patch set 13 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #95

Updated by Gerrit Code Review over 2 years ago

Patch set 14 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70513

Actions #96

Updated by Elias Häußler about 2 years ago

  • Related to Bug #98222: Inconsistent form rendering after #93887 added
Actions #97

Updated by Oliver Hader about 2 years ago

  • Related to Bug #98084: Honeypot not working anymore? added
Actions #98

Updated by Oliver Hader about 2 years ago

  • Related to Bug #98336: Revert modified cache handling in form framework added
Actions #99

Updated by Christian Kuhn about 2 years ago

  • Status changed from Under Review to New

this has been reverted with https://forge.typo3.org/issues/98336

Actions #100

Updated by Helmut Hummel over 1 year ago

  • Sprint Focus deleted (Remote Sprint)

@Heiko Fischer Can you provide more information of how exactly you render the form via TypoScript?

If it is something along those lines provided by the test extension here, I tend to close this as won't fix.
The view helper provided by the form extension must not be used outside the context of it's accompanied controller.

Actions #101

Updated by Garvin Hicking 4 months ago

  • Status changed from New to Needs Feedback

Setting this to "needs feedback", if I read this right, the issue would be regarded as a "wontfix" otherwise?

Actions

Also available in: Atom PDF