Bug #93942
closed
Remove Imagecropping at SVG Files?
Added by Michael Kasten about 3 years ago. Updated about 1 month ago.
100%
Description
Testet on https://demo.typo3.org (10.4.14):
- Upload a svg File
- Create a text/media CE
- Choose the svg as media
- Crop the image
- Save the content -> Quits with an Error
- Editing is not possible fourthermore exept deleting this CE in Listview
I guess maybe it would better to create a set of possible image formats for the cropping tool?
Files
| vokoscreen-2021-04-19_08-58-40.mp4 (416 KB) vokoscreen-2021-04-19_08-58-40.mp4 | Michael Kasten, 2021-04-19 07:06 |
Updated by Martin Kutschker almost 3 years ago
Technically it could be cropped by modifying the SVG element's attributes.
Updated by Garvin Hicking 8 months ago
- Target version set to 13.0
- TYPO3 Version changed from 10 to 13
- PHP Version set to 8.1
- Complexity changed from easy to medium
I took the liberty to hijack this issue to implement SVG imagecropping.
PR incoming.
Updated by Gerrit Code Review 8 months ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 8 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 8 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 8 months ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 8 months ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 8 months ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 8 months ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 8 months ago
Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 8 months ago
Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 8 months ago
Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 7 months ago
Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 7 months ago
Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 7 months ago
Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 7 months ago
Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Benni Mack 7 months ago
- Related to Bug #77190: ImageMainpulation for SVG only scales but does not crop added
Updated by Gerrit Code Review 7 months ago
Patch set 15 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Garvin Hicking 7 months ago
The current patch set 15 seems to work well with a content image crop.
It also works when using i.e. a flexform or a custom content element and <f:image> with an image=... FAL reference.
However, it does not work when using a <f:image src="..."> definition. Probably because $task->getTargetFile()->updateProcessingUrl(...) is only used for file references with attached crops, but not locally sourced static files? Sadly I don't know where to dig in the reorganized code to make it work for this. The SVG is passed through, but the '#svgBox...' URI fragment is missing.
Bonus task: Currently it seems using <f:image ... fileExtension="png"> does NOT enforce rending an SVG through a PNG process.
I've created a simple extension showcasing the issue (required applied patch):
Updated by Christian Kuhn 6 months ago
- Related to Epic #101608: File Abstraction Layer Changes for v13 added
Updated by Gerrit Code Review 6 months ago
Patch set 16 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 5 months ago
Patch set 17 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 5 months ago
Patch set 18 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 5 months ago
Patch set 19 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 5 months ago
Patch set 20 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 4 months ago
Patch set 21 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 4 months ago
Patch set 22 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 4 months ago
Patch set 23 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 4 months ago
Patch set 24 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 4 months ago
Patch set 25 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 4 months ago
Patch set 26 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 4 months ago
Patch set 27 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 4 months ago
Patch set 28 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 4 months ago
Patch set 29 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 3 months ago
Patch set 30 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 3 months ago
Patch set 31 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 3 months ago
Patch set 32 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 3 months ago
Patch set 33 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review 2 months ago
Patch set 34 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 2 months ago
Patch set 35 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 2 months ago
Patch set 36 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 2 months ago
Patch set 37 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 2 months ago
Patch set 38 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 2 months ago
Patch set 39 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 2 months ago
Patch set 40 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 2 months ago
Patch set 41 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 42 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 43 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 44 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 45 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 46 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 47 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 48 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 49 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 50 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 51 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 52 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 53 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Gerrit Code Review about 1 month ago
Patch set 54 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617
Updated by Garvin Hicking about 1 month ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 747b9bb113af2a087edd6615596ebdd224058d21.