TYPO3 Core

Troubles with URL encoding? A plain + in a URL means space, just like %20.

Hi Riccardo,
maybe you can't reproduce the bug because the files with "+" in the name are renamed replacing "+" with "_" if uploaded via TYPO3.

Instead the problem arise when the file have "+" in the filename when already in the fileserver in case it has been uploaded externally of TYPO3 so not renamed.

Use case: an editor has a "sky+one.jpg" file and wants to replace it. The editor uploads a new file to replace it and TYPO3 informs him that he replaced the file when in fact it didn't and uploaded the new file. If this file is in a long list of files, the editor probably won't even notice what happened.

Sure this is a minor bug because it affects a rare use case, but it shouldn't be treated as expected behavior IMHO.

@Christian Toffolo I am saying is that the scenario in which

1. There is already a file on filesystem named sky+one.jpg that for some reasons has not been handled by the TYPO3 filename sanification process

2. The editor uploads a file using the TYPO3 interface with the same name: sky+one.jpg .
This time the filename sanification is triggered, so the file is renamed sky_one.jpg

3. TYPO3 does not know that there's already a file named sky+one.jpg, so this is kept and a new one called sky_one.jpg is added while the old file is kept.

Seems IMHO what should happen and so I think this might be a feature and not a bug... maybe I'm wrong. I would like to know opinions on that.

Why this happens? I guess that the actual file comparison and overwrite process seems to happen after the sanification process.
as proof of this, if I try to upload ANOTHER file (still using TYPO3) still named sky+one.jpg, the "warning modal" says that there is already a file named sky_one.jpg, not sky+one.jpg!

Would it be wise to alter the order of execution of these processes? what would happen in this case

1. there is already sky+one.jpg on disk
2. editor uploads sky+one.jpg using TYPO3
3. TYPO3 compares sky+one.jpg (old) to sky+one.jpg (new) -> the filenames are identical -> asks if it should be overwritten -> if answer is YES ->
4. TYPO3 overwrites the file
?? 5. TYPO3 sanitizes the filename to sky_one.jpg
?? 6. TYPO3 deletes sky+one.jpg

right? Or do you think that in this case the sanification process should be skipped at all?

I also wonder what would happen if for some reason there are on disk files named:

sky+one.jpg
sky one.jpg

if you upload sky+one.jpg what would happen? just the first is replaced?

I suggested that the anomalous situation about the presence of files not sanitized by TYPO3 could be handled ex post using a scheduled process or something similar.

For the use case of this issue, the editor is not simply uploading a file using the TYPO3 interface, the editor is replacing a file using the replace tool of TYPO3.
Maybe you are missing this important difference.