Project

General

Profile

Actions

Task #95098

closed

Modals use semantically wrong declaration

Added by Björn Jacob over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Dashboard
Target version:
-
Start date:
2021-09-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

I am aware of 4 wizards:

1. new content element wizard (page module)
2. translation wizard (page module)
3. new dashboard wizard
4. new form wizard

The severity of those modals and the primary buttons (if available) are declared as follows:

1. new content element wizard
  • modal: notice
  • button: n/a
2. translation wizard
  • modal: notice
  • button: info
3. new dashboard wizard
  • modal: notice
  • button: warning
4. new form wizard
  • modal: info
  • button: info
5. Show columns for page (introduced in v11)
  • modal: notice
  • button: info
7. install tool login
  • modal: warning
  • button: warning

The severities are described as follows:

  • notice: non-actionable statement
  • info: actionable statement
  • warning: negative connotation, something will "go wrong"
  • error: negative connotation, something "went already wrong"

This should be
a) fixed
b) somehow documented

Regarding a) IMHO the severity "info" would be the way to go since the modals require actions/ are actionable. As it can be seen in the new dashboard modal the severity is used for styling purposes:

This must never be the case. As we all know: form follows function (semantic) :).
That said, further adaptions to the styling of those severities could be made.


Files

form-framework.png (37.4 KB) form-framework.png Simon Schaufelberger, 2022-03-26 00:47
dashboard.png (25.8 KB) dashboard.png Simon Schaufelberger, 2022-03-26 00:50
show-columns-for-page.png (97.5 KB) show-columns-for-page.png Simon Schaufelberger, 2022-03-26 00:58
install-tool-login.png (13 KB) install-tool-login.png Simon Schaufelberger, 2022-03-26 00:58
after.png (25.6 KB) after.png Simon Schaufelberger, 2022-03-26 01:36

Related issues 1 (1 open0 closed)

Related to TYPO3 Core - Task #81238: Streamline severity and message of delete modalNew2017-05-17

Actions
Actions #1

Updated by Mathias Brodala over 2 years ago

  • Description updated (diff)
Actions #2

Updated by Martin Kutschker over 2 years ago

Abusing semantic markup for styling is an absolute no-go when the BE ever should become accessible.

Actions #3

Updated by Riccardo De Contardi over 2 years ago

  • Related to Task #81238: Streamline severity and message of delete modal added
Actions #4

Updated by Simon Schaufelberger about 2 years ago

Actions #5

Updated by Simon Schaufelberger about 2 years ago

  • File deleted (dashboard.png)
Actions #7

Updated by Simon Schaufelberger about 2 years ago

  • Complexity set to easy
Actions #8

Updated by Simon Schaufelberger about 2 years ago

  • Description updated (diff)
Actions #10

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74064

Actions #12

Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF