Bug #96723
closed
EmailViewHelper escapes linktext
100%
Description
Since 11.5.5 the linktext is escaped with htmlspecialchars(). This conflicts with the use of markup in spamProtectEmailAddresses_atSubst or spamProtectEmailAddresses_lastDotSubst like
config.spamProtectEmailAddresses_atSubst = <span class="at"></span>
or additional markup for Icons and such.
Anyone know if that is intentional? Feels like a regression to me.
Updated by Georg Ringer almost 3 years ago
- Related to Bug #96483: EmailViewHelper does not use typolink added
Updated by Oliver Hader almost 3 years ago
- Status changed from New to Needs Feedback
I could not reproduce using regular rich-text with the following TypoScript settings in TYPO3 v11.5.6.
config.spamProtectEmailAddresses = 2 config.spamProtectEmailAddresses_atSubst = <!--nomorespam--><span class="at"></span>
Outputs the following:
<a href="#" data-mailto-token="ocknvq,qnkxgtBvarq50qti" data-mailto-vector="2">oliver<!--nomorespam--><span class="at"></span>typo3.org</a>
How is the link generated on your side?
Updated by Gerrit Code Review almost 3 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73355
Updated by Oliver Hader almost 3 years ago
- Status changed from Under Review to Needs Feedback
Updated by Oliver Hader almost 3 years ago
Just pushed a test-case for the mentioned scenario "markup in atSubst" to https://review.typo3.org/c/Packages/TYPO3.CMS/+/73355
Updated by Christina Böhme almost 3 years ago
I have a tt_address item in list view and a custom fluid template. This is the relevant part in the Address partial:
<f:section name="contact">
<p class="paragraph">
<f:if condition="{address.email}">
{f:translate(key:'label.email')}
<f:link.email email="{address.email}" class="content-text-image__anchor anchor anchor--underline" />
</f:if>
</p>
</f:section>
Which gives me this output for the mailto link:
<a class="content-text-image__anchor anchor anchor--underline" href="#" data-mailto-token="hvdgoj5cvin9oznozmVozno9xjh" data-mailto-vector="-5">hans.tester<span class="at"></span>test<span class="dot"></span>com</a>
Updated by Gerrit Code Review almost 3 years ago
- Status changed from Needs Feedback to Under Review
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73355
Updated by Gerrit Code Review almost 3 years ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73287
Updated by Oliver Hader almost 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f2e2545414cbf144040c214a85e94cff1aee3efe.
Updated by Oliver Hader almost 3 years ago
- Status changed from Resolved to Accepted
Updated by Oliver Hader almost 3 years ago
- Status changed from Accepted to Resolved
Applied in changeset 7021661658c2e8e149fc4b93fd8dd03997636a86.
Updated by Gerrit Code Review almost 3 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73363
Updated by Gerrit Code Review almost 3 years ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73364
Updated by Gerrit Code Review almost 3 years ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73363
Updated by Oliver Hader almost 3 years ago
Hey Christina, thanks for providing examples - this helped me to understand, that the flaw is in the view-helper implementation, and not to be located in typolink (which seemed to be fine already).
Updated by Gerrit Code Review almost 3 years ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73363
Updated by Gerrit Code Review almost 3 years ago
Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73364
Updated by Christina Böhme almost 3 years ago
The patch is working for me, thanks Oliver!
Updated by Gerrit Code Review almost 3 years ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73363
Updated by Gerrit Code Review almost 3 years ago
Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73364
Updated by Oliver Hader almost 3 years ago
- Status changed from Under Review to Resolved
Applied in changeset 77a715ec4fe3290e931879d4836799c586212308.
Updated by