TYPO3 Core

https://review.typo3.org/c/Packages/TYPO3.CMS/+/72005 via Bug #95819: Extbase does not support uninitialized domain object properties

I suggest filtering out private properties, just like get_object_vars() did (to be able to backport as bugfix) and reintroduce @Transient for the upcoming version 12. I am sorry that bug slipped through.

Alexander Schnitzler wrote in #note-4:

I suggest filtering out private properties, just like get_object_vars() did (to be able to backport as bugfix) and reintroduce @Transient for the upcoming version 12. I am sorry that bug slipped through.

Can you please provide a patch for that?

The change in #95819 generally is okay. It basicly behavious as before. This
means, that properties beginning with $_ are already ignored. However, there
was a slight oversight with the change from AbstractDomainModel->_getProperties()
to ReflectionService->getClassSchema() and the following loop in class methods
\TYPO3\CMS\Extbase\Persistence\Generic\Backend->insertObject() and
\TYPO3\CMS\Extbase\Persistence\Generic\Backend->persistObject().

As $propertyName and $propertyValue are not included, code has been added to rertieve
them in the loop. Getting the $propertyValue is however done to early and should only
be called if property is callable.

Patch will follow.

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534

Beside that it worked before and broke - maybe it is wise to use the "_" prefix for the property, even if it is private and not defined in TCA. The prefix also works for "protected" properties.

I'm getting errors in object validation when calling a detail action, like e.g. (having the patch applied).

(1/1) #1546632293 RuntimeException
Could not get value of property "ExtbaseTeam\BlogExample\Domain\Model\Blog::oida", make sure the property is either public or has a getter getOida(), a hasser hasOida() or an isser isOida().

I'm trying the approach Alex suggested with filtering the properties...

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534

The annotation issue I mentioned earlier is a different topic and did exist prior to #95819 - short summary on it:

class Parent extends AbstractEntity
{
  protected Child $child;
}

use TYPO3\CMS\Extbase\Annotation\Validate;
class Child extends AbstractEntity
{
  /**
   * @Validate("StringLength", options={"minimum": 1, "maximum": 80})
   */
  public string $title = '';
}

class ParentController extends ActionController
{
  public function showAction(Parent $parent): ResponseInterface
  {
    // ...
  }
}

Action Parent.show gets argument of type Parent, which has a non-accessible property to type Child, which has a validation rule of a property. Following the validation chain is correct in general, unless some part of it cannot be accessed (which is protected property Parent::$child in this example).

In case validation for internal values is desired/expected, this probably would be something for reflection.
In case developers would "need to adjust their code", current RuntimeException (#1546632293) is semantically wrong, it has to be a LogicException instead.

→ I've create issue #98190 for that particular validation issue

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75541

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75541