Project

General

Profile

Actions

Bug #102656

closed

Exception in record history with outdated content element configuration

Added by Georg Ringer 7 months ago. Updated 8 days ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Start date:
2023-12-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Given is a content element which is not relevant anymore and the ctype has been removed and the content element deleted.
switching to the record history brings up an exception

TCA misconfiguration in table "tt_content" field "pi_flexform" config section: ds_pointerField "list_type" points to a field name that does not exist.

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #102655: Page history crashes - ds_pointerField "list_type" points to a field name that does not exist.Closed2023-12-12

Actions
Actions #1

Updated by Gerrit Code Review 7 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82174

Actions #2

Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82174

Actions #3

Updated by Christoph Lehmann 7 months ago

  • Related to Bug #102655: Page history crashes - ds_pointerField "list_type" points to a field name that does not exist. added
Actions #4

Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82174

Actions #5

Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82174

Actions #6

Updated by Georg Ringer 4 months ago

  • Status changed from Under Review to Rejected

won'T fix

Actions #7

Updated by Daniel Schultheis 4 months ago

Is there a specific reason why this issue has been rejected and won't be fixed?

I've stumbled into the exact same problem where a content element that utilized the pi_flexform field has first been edited and later was deleted now throwing this exception when the history view is opened.

It looks like FlexFormValueFormatter::format() which is called in the process is still continuing with the formatting logic although BackendUtility::getRecord() could not retrieve a record as it had already been deleted.

Should FlexFormValueFormatter::format() then not just return an empty string instead of trying to retrieve the flexform data-structure from a non-existing record leading to the exception mentioned here?

Actions #8

Updated by Gerrit Code Review 3 months ago

  • Status changed from Rejected to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83648

Actions #9

Updated by Daniel Schultheis about 1 month ago

Sorry to bother again but are there any updates on this issue as it has been under review for two months now.

Actions #10

Updated by Garvin Hicking about 1 month ago

There's been an implementation of a patch in the linked Gerrit patch tracker: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83648

You could help push things forward if you are able to test the patch and give feedback if it helps you, ideally directly in the Gerrit tracker via voting.

Since this is an OpenSource project it sadly happens that issues stall and the people implementing bug fixes may not be able to keep up. In that case, any help is appreciated :-)

Actions #11

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83648

Actions #12

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83648

Actions #13

Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84643

Actions #14

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84643

Actions #15

Updated by Christoph Lehmann about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #16

Updated by Gerrit Code Review about 1 month ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84643

Actions #17

Updated by Tim Spiekerkötter 22 days ago

Hi guys,

we stumbled up on the same problem and without looking for the solution we found that the getRecord supports using $useDeleteClause = false . We tried using it that way and with that the history can also show the plugin options changes again.

I don't know if we are too late here, but I guess that would be a 'better' solution?

Maybe someone can have a look at that and decide whether that would be better:

# typo3/cms-backend/Classes/View/ValueFormatter/FlexFormValueFormatter.php:48
$record = BackendUtility::getRecord($tableName, $uid, '*', '', false) ?? [];

Cheers,
Diego

Actions #18

Updated by Gerrit Code Review 20 days ago

Patch set 4 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84643

Actions #19

Updated by Gerrit Code Review 17 days ago

Patch set 5 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84643

Actions #20

Updated by Christoph Lehmann 16 days ago

  • Status changed from Under Review to Resolved
Actions #21

Updated by Benni Mack 8 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF