TYPO3 Core

+1 for "undo changes"

Imho "Undo" instead of "Undo changes" would fit a bit better, especially because the other two labels are also quite short ("Publish", "Swap") ;) - any opinions?

I'm unsure. Just "Undo" may cause confusion because it might lead users to think that they can undo the latest action that they performed in the BE module.

Maybe my other proposal "Cancel changes" is better after all.

BTW (but maybe this should be a separate issue), I thought some more and there should be a real consistency between the various actions in the various places were they can be performed. I mean that you should be able to publish, swap or "cancel/undo" no matter whether you are hovering over one item (the icons in the grid row), choosing an action after having selected one or more modified items or choosing a mass action. The only action that shouldn't be "mass" is the sending to another stage.

This leads me one step further: I also think that "mass action" is not a good wording. Indeed when you have selected several modified records and choose an action you are de facto performing a mass action. I would suggest to move the mass action menu out of the data grid, to more clearly show that it is not related to a selection performed in the grid. OK, this is definitely the topic for another issue, but I'm a bit in a hurry right now and just wanted to write it down.

I agree with Tolleiv, I would take "Undo" as it is short. But I would then use a clear description in the popup like "Undo all changes from whole workspace".

I agree with Tolleiv, I would take "Undo" as it is short.

The length of the label should not be a criterion of choice. What should guide us is that the label should be explicit enough. I still think that just "undo" is a bad idea, because it may lead users to think that they can undo the actions they have just taken (especially since - as I still think - the mass action menu is ambiguously place in the interface IMO). Even "undo changes" might not be clear enough. Maybe "cancel changes" is the better choice.

Tolleiv Nietsch wrote:

Or favorite is "rollback ..." - but we're going to ask the HCI team

Rollback sounds good, I'd throw in "Discard", too to add more choices ;)

I wouldn't go with Undo though as that usually is related to the last/previous action. I'm also for leaving out changes since all of them are related to changes. When adding changes, it'd be more consistent to add changes to all of the options which would then obviously be very redundant...

So we got than:

1. Publish
2. Swap
3. Release

I would also go for:

1. Publish
2. Swap
3. Discard

In the screens (#10642) we sad:

1. Publish
2. Swap
3. Reject
4. Drop Changes

We should ask a native speaker about that.

Did someone ask for a native speaker? :)

Jens and I had a brief chat about this and I think "Discard" would be the right choice for the verb (something more descriptive like Discard Changes is fine too).

For the English version, the key thing is that the changes are in a temporary state which will be thrown away. Revert or undo make sense if the live record was being returned to its previous state, but not for this temporary state.

Thanks,
Jeff