TYPO3 Core

I can report another variant related to this issue. I upgraded a TYPO3 4.4.x install which contains a custom workspace to 4.5beta3 and the old User Tools->Workspace tool was updated to the new Web->Workspaces extension. I ran the Update Wizard (Versioning and Workspaces: Migrate "draft" workspace) and I assume that wizard was responsible for updating to the new extension, but I'm not 100% sure.

However, the 4.4.x install did not have either Fluid or Extbase installed, and they weren't installed by the update process, which required the new Workspaces extension to be removed from the localconf config file manually before the backend would operate correctly.

If this should be logged as a separate issue, let me know.

--Mark

see RFC #16630 in Core list

Ah, sorry Tolleiv. IIRC workspaces was really not installed and so I had a look at class.tx_coreupdates_installversioning.php, which is obviously the 4.3 upgrade wizard - which is obselete and should be removed?

After looking again: We must remove this upgrade wizard! The text is totally misleading:

Versioning and Workspaces: Install System Extension

The extension "version" is not loaded. Since TYPO3 4.3 the extension "version" is no longer required. Therefore it is not enabled by default if you update an existing TYPO3 installation. If you use versioning and workspaces in your installation you might install the extension "version" directly from here - in case you don't need versioning and workspaces leave "version" disabled because it needs quite a lot performance. Enable versioning and workspaces Install extension "version"

Of course, it says "Install extension version", but who reads this ;-)

fullACK the old wizard has to be removed - I'm going to bring up that RFC this evening or tomorrow.

1) RFC 16630 has been committed meaning no more "crash" on using the migration wizard of workspaces when extbase was not installed before

2) the version installation wizard is not obsolete as discussed here, because it might be useful for someone that doesn't even want to use workspaces. See discussion on RFC 16935 upon that.

So I guess this particular issue is obsolete, but the usability of the whole "migration" could be probably checked again. In my case the upgrade wizard for workspaces is always showing up, even if it did ran several times already. I am not sure if this is just my environment, or a general problem.

My intention with suggesting to install both sysexts without further requests was to prevent too much choices (two wizards for almost the same thing). If user really doesn't want to use workspaces, he can uninstall it afterwards.

Nevertheless, as long as it's easily visible to the user that there is a new workspace sysext, I'm totally fine :)

I was pointed here by Ernesto to continue the discussion about problems regarding the workspace related wizards. To repeat what I observed in the core mailing list, one issue is that the workspace migration wizard activates itself based on the count of sys_workspaces. But if you have activated the "version" extension in a TYPO3 4.4 install, but have chosen not to have the Draft workspace and have not created a custom workspace, the sys_workspaces table is empty. So the wizard does nothing, the stages table is not created. If you then try to create a workspace at some point in the future, it will break because a table is missing.

@Ernesto - thanks for taking care of the pending patch, I will provide an improved version of it as follow-up

@Francois Suter - you're right the circumstances under which the wizard is triggered need to be rechecked - I plan to do this as separate issue of course ( #12146 ). Since I wrote most of the code for the current wizard it seems that it wasn't a good idea to split up the actual wizard into three chunks for the original RFCs - this even changes some of the original idea when the wizard becomes relevant and when it doesn't. But anyways - I will have time to rethink and rebuild this functionality on my flight on Friday and try to come up with a reasonable and working concept for this afterwards

@all review - we still need a decision how to proceed with the "version" installer wizard - should me keep it but make both wizards mutually exclude each other or should we get rid of the "installversioning" for the sake of simplicity (but make sure that the migrateworkspaces actually works in all cases)

Since I don't find it very desirable to have "version" standalone I'd prefer to get rid of "installversioning" - but I agree with Ernesto that my "quick" way of just removing the wizard is also wrong as long as the migrateworkspaces doesn't really work every time. But these are just my two cents - whatever the decision for this is I will spent time on it to have working solution.

Btw. besides that I still think that http://bugs.typo3.org/view.php?id=16926 / #11638 as a standalone request makes sense - so it would be great if anyone could review it too.

see http://bugs.typo3.org/view.php?id=17102