Project

General

Profile

Actions

Bug #11825

closed

non-admin editors can't see non-page records within the review module

Added by Mark Johnston over 13 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Workspaces
Target version:
-
Start date:
2011-01-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In a TYPO3 4.4.x install, the editors of a custom workspace have access to the Web->Versioning module, but not the User Tools->Workspace tool. This is sufficient to provide the means to send individual items that have been contributed by the user to review. When upgrading to 4.5beta3 this capability is lost, because the Web->Versioning module is not shown.

The Web->Versioning module should be shown if the user is configured to access it and the Web->Workspaces module is not installed OR not configured for access by the user.


Files

Admin_Workspace_view.png (20 KB) Admin_Workspace_view.png Inside Workspace tab, Admin can see the updated News article Mark Johnston, 2011-01-16 01:50
Basic_Editor_Workspace_view.png (19.2 KB) Basic_Editor_Workspace_view.png Inside Workspace tab, non-admin editor cannot see the updated news article Mark Johnston, 2011-01-16 01:54
11825.patch (1.16 KB) 11825.patch Tolleiv Nietsch, 2011-01-16 11:54

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #11218: Workspaces Module shall be shown after Versioning ModuleClosedOliver Hader2010-12-02

Actions
Actions #1

Updated by Tolleiv Nietsch over 13 years ago

  • Status changed from New to Needs Feedback

Well that's how it's done at the moment:

if (!t3lib_extMgm::isLoaded('workspaces')) {
t3lib_extMgm::addModule('web', 'txversionM1', '', t3lib_extMgm::extPath($_EXTKEY) . 'cm1/');
}

We decided to use the behavior because using versioning when workspaces are present might cause further issues.

And why would you remove access to the workspace-module for an editor if you want him to be part of the workflow and at the same time why would you grant him access to the versioning module?

Actions #2

Updated by Mark Johnston over 13 years ago

I've seen the code snippet in the version ext_tables modlue on our test site (4.5.0beta3), and all I can report at this time is that it is not effective to load the version module for users not configured for access to the workspaces module.

I will be willing to research this more thoroughly, but as far as I can tell, some form of call to the modAccess() function would be required to determine the current user's access to the workspaces module.

The reason for this configuration, which we are currently successfuly using in our production 4.4.x site, is that the version module offers a simplified user interface for editors that still allows them to participate in the workflow, since version does present the necessary workflow controls in its UI.

In our case, simpler is definitely better, at least for now. The version capability focuses on changes pending in a single page or folder rather than being global to the workspace and we see that as an advantage for our editors in our use of TYPO3. Even though the new workspaces extension does offer the capability to display changes in a single tree, the automatic selection of infinite as the recursion level is too broad for us, I think.

Actions #3

Updated by Tolleiv Nietsch over 13 years ago

Well but switching on the old module is not a good option at all - I'd rather make the depth-selection-box configurable than enabling both modules side-by-side.

Actions #4

Updated by Tolleiv Nietsch over 13 years ago

Mark - is this issue still relevant for you or can we close it?

Actions #5

Updated by Mark Johnston over 13 years ago

I'm still having issues with non-admin user access to workspace functionality even after adding Workspaces as a module for the non-admin user.

Actions #6

Updated by Tolleiv Nietsch over 13 years ago

So how to proceed? Using both side-by-side is no option here.

Actions #8

Updated by Mark Johnston over 13 years ago

The "Basic Editor" (non-admin) user is able to add and update items in the workspace, but even with the Workspaces extension enabled cannot see the workflow functionality. I've uploaded two screenshots of the same folder with each logged in that shows the issue.

As mentioned, this behavior is happening on an upgrade of a completely functional workspace from TYPO3 4.4.x to 4.5.0beta3 (actualy the workspace was originally set up in a v4.2.x site that has since been upgraded).

I've tried to set up a new site based on a fresh TYPO3 demo site on 4.5.0beta3, but so far have not been able to achieve successful access by a non-admin user to a configured workspace at all. I don't know of any comprehensive documentation for site administration of the new custom workspace functionality at this stage of its development, so I figured my next steps might most productively be to add a configuration page to the wiki for this project. Whatever missteps I am making can then be commented on, and the result should be a beginning point for the missing documentation.

If you know of any successful non-admin test installation, I'd be glad to try to integrate an export of such into a new 4.5.0beta3 install to 1) verify that I can make it work, and 2) if it is working, identify how it is different from the way I have been trying to do it.

Actions #9

Updated by Tolleiv Nietsch over 13 years ago

What has all this to do with "Web>Versioning"? This seems to be a bug - but bringing up "Web>Versioning" is totally wrong at this point.

Actions #10

Updated by Mark Johnston over 13 years ago

Well, I'm focusing on the non-admin user aspect of the report, but you are focusing on the Web->Versioning aspect. The bottom line is that there are currently problems for non-admin users to use the new workspaces functionality. If that should be a new issue report, I'd be up for that.

There should eventually be some written documenation that clarifies how upgrades to Workspaces 4.5 should be administered with the changes being introduced compared to earlier versions of TYPO3, since this is one example of how a successfully operating configuration may break on the upgrade. If that's already planned in a separate action (and I will be happy to contribute if I can be helpful), this ticket can be closed.

Actions #11

Updated by Tolleiv Nietsch over 13 years ago

Well showing "Web>Versioning" was your request - the fact that there might be a bug within the existing module wasn't really mentioned in your first reports. I'm going to open a new bugreport. This one is too long to motivate others to look at it ;)

Actions #13

Updated by Tolleiv Nietsch over 13 years ago

  • Status changed from Needs Feedback to Under Review
  • Assignee set to Tolleiv Nietsch
  • Target version set to 4.5 RC1

RFC sent to workspace-list. I was able to find the actual problem and creating a new bugreport is imho not required. But we've to find someone who's able to rename the issue ;)

Actions #14

Updated by Susanne Moog over 13 years ago

  • Subject changed from Non-admin editor with access to Web>Versioning module only loses workflow ability on upgrade to non-admin editors can't see non-page records within the review module
Actions #15

Updated by Sonja Schubert over 13 years ago

  • Status changed from Under Review to Resolved

Commited to trunk (rev 3831)

Actions #16

Updated by Michael Stucki over 10 years ago

  • Category set to Workspaces
Actions #17

Updated by Michael Stucki over 10 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
  • Target version deleted (4.5 RC1)
Actions #18

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF