TYPO3 Core

I can confirm this. See the attached image. The highlighted page-name should be "Übungsleiter". There is an error on character encoding for the AJAX response.

Please see the attached file 0004814.patch which should solve the problem.

patch works fine. great!

Don't use utf8_encode. TYPO3 has an API for that kind of stuff (quoted from memory):

$LANG->csConv->utf8_encode($string)

In doubt see lang.php and class.t3lib_cs.php

In fact, you should call it with $GLOBALS['LANG']->charSet as 2nd attribute.
$GLOBALS['LANG']->csConvObj->utf8_encode($this->content,$GLOBALS['LANG']->charSet);

See similar case in alt_clickmenu.php, function printContent().

hey oliver. Thanks for the patch. Just found out the problem by myself. :-)

a) Thanks for the backpath - stuff. I forgot that while coding.
b) The same procedure has to be done in the alt_file_navframe.php
c) Also use Stucki's recommendation with the csConv.

Once the changes are in the new patch, we're good to go to get this in SVN!

Please see 0004814_2.patch

What have I done:
1) Added a conversion to utf-8, dependent to the existing encoding, as suggested by Masi
2) Added header that is set to 'Content-type: text/html; charset=utf-8' - before mimemagic determined these settings, now it's told what to do
3) Wrapped $this->doc function calls and instances in an if-statement - it's not necessary to create an instance of template, set variables etc. if they are not used on an AJAX call

What do you think?

hey oliver. looks very good. But haven't used it yet. I'm gonna patch my 4.1beta3 with it tomorrow morning and get back to you ASAP, so you can send it to the core list. sorry for the delay.

Hey Oliver,

one other thing that came to my mind while recoding the tree with prototype would be that we would instantiate the prototype library only ONCE per call.
Otherwise if somebody would like to include some other features AND the tree.js and it both loads the prototype library, it's not that nice. That's why I got this idea:

let's create a function in template.php with the singleton pattern and a static variable:
----
function includePrototypeLibrary() {
static $included = false;
if (!$included) {
$included = true;
$this->JScode .= '<script type="text/javascript" src="'.$this->backPath.'prototype.js"></script>';
}
}
----

Maybe we could add that small change too within the cleanup. The nice thing is that it makes it easier other developers to use this library without them having to think about what else is used on this page. Should we open another issue for this?

Hi Benjamin,

good idea with adding a includePrototypeLibrary(). But I would add this into t3lib_div or some other common library. It is possible the extension developers want to use prototype.js in Frontend as well - template.php is for Backend only.

To avoid including the javascript framework more than once, I'd suggest to set a global variable like $GLOBALS['JSincluded']['prototype']=true so that even other moduels (no matter of FE or BE) know, that this was already included.

What do you think?

sounds great. Would you make a patch for this?
Btw: Should we discuss this on the dev-list where to put the library? Most of the people will suggest "well, then make an extension out of it" ;-).

Actually. Let's open up a new issue for this because then the umlaut bugfix can go into the core-list right away. Patch "0004814_2.patch" works fine!

The further discussion on including/libs/etc. can be found at bug #16900.

Committed to Trunk.
(only 0004814_2.patch, no additionals)