Feature #19152

Remove JS popup when login expired

Added by Christoph Koehler about 11 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2008-07-25
Due date:
% Done:

0%

PHP Version:
5.2
Tags:
Complexity:
Sprint Focus:

Description

As part of 4.3 I implemented this idea.
Patch is attached, please provide feedback.

This is how it works now:
30 seconds before the login expires, a modalbox window slides down with a countdown of 30 seconds and a button to refresh the login. This does not require username/password, it simply extends the current session.

Once the countdown expires, a login form is automatically loaded. Login will refresh the session and the internal timer and allow the user to continue work as before.
(issue imported from #M9052)

modalbox.zip (15.7 KB) Administrator Admin, 2008-07-25 17:59

error popup.png View (248 KB) Administrator Admin, 2008-07-25 21:30

9052_modal_login_7.diff View (24.3 KB) Administrator Admin, 2008-11-04 08:44

9052_modal_login_13.diff View (26.3 KB) Administrator Admin, 2009-01-08 18:11


Related issues

Related to TYPO3 Core - Feature #19586: After auto Logout the Clear Cache function stil appears to be working, but of course it does nothing Closed 2008-11-10
Related to TYPO3 Core - Bug #19841: Backend not usable in Internet Explorer anymore Closed 2009-01-16
Related to TYPO3 Core - Bug #19897: Bad interaction between OpenId auth and ExtJS relogin box Closed 2009-01-23
Related to TYPO3 Core - Feature #15422: Make "Login-error or session timed-out" - page configurable Closed 2006-01-15
Related to TYPO3 Core - Bug #21542: Ajax-Relogin uses hardcoded label "Please wait" (although translation is present) Closed 2009-11-12
Related to TYPO3 Core - Feature #15631: BE should reload when a new session with another user is created Closed 2006-02-15
Related to TYPO3 Core - Bug #18944: "Clear Cache" commands in toolbar not complaining when session has expired Closed 2008-06-12
Related to TYPO3 Core - Bug #33759: AJAX login doesn't work with RSAauth and Salted pass Closed 2012-02-08

History

#1 Updated by Christoph Koehler about 11 years ago

Changed patch file to exclude new files and attached the new files as a .zip. They need to go into typo3/contrib.

#2 Updated by Ingo Renner about 11 years ago

what license is modal box?

#3 Updated by Christoph Koehler about 11 years ago

MIT. There is a bug with IE (imagine that) that I am still trying to figure out.

#4 Updated by Ingo Renner about 11 years ago

MIT... so most likely it's actually X11, but this should be ok with the GPL anyways

#5 Updated by Ingo Renner about 11 years ago

some points about your patch:

  • the class should go into typo3/classes/
  • the license header is missing
  • phpDoc is missing
  • xclass definition is missing
  • don't use tables for layout
  • don't use inline html (though it is debatable here)
  • the patch doesn't apply directly as it's not relative to the TYPO3 root directory (a, b at the beginning)
  • include the modal box sources in the patch
  • try using TYPO3's spinner, there should be one in typo3/gfx/ or so

#6 Updated by Ingo Renner about 11 years ago

... ok the spinner can stay, looks good.

However, I get an error as in the attached scrrenshot

#7 Updated by Christoph Koehler about 11 years ago

Thanks, will look at those.

tables for layout: Copied and pasted the html from the current login box in index.php, but will change that.

inline html: I assume you mean the return values of the ajax methods. We can talk about that.

patch: yeah, will change that, too.

modalbox source: benni asked me to zip it since it contains binary files (the spinner)

spinner: it's included in the modalbox, i would have to change the source to switch.

#8 Updated by Christoph Koehler about 11 years ago

hmm odd. Works fine in Safari here. Wonder if the patch is borked...

#9 Updated by Benni Mack about 11 years ago

Hey Christoph,

my first remarks:

a) Your new class and all its methods does not have any comments nor License infos. Please add them.
b) Also, use PHP5 style methods (public / protected) for new functions
c) Don't echo anything directly. The AJAXObj will handle the output. Have a look at the TYPO3AJAX class and how it is used in other places in the core on how to return code as you want it.
d) Don't know if you need to urlencode this: "ajaxID=BackendLogin%3A%3AForm'

#10 Updated by Ingo Renner about 11 years ago

more comments:

  • avoid inline css styles, put them into classes
  • try to stay within 80 characters/line

#11 Updated by Christoph Koehler about 11 years ago

Added file 9052_modal_login_2.diff with the newest changes.

I took most of the suggestions here into account.

I also changed the way that TBE_EDITOR determines a timeout. This will need some testing.
I changed jsfunc.tbe_editor.js slightly to use the busy.busyloadTime instead of the TBE EDITOR internal time, making it a little more unified.
It seems to work properly so that now, when you are editing a record and your login is timing out, once you relogin, the warning that your login expired will not show anymore.

Apply the patch and stick the files from the modalbox.zip archive into the contrib directory, so that it will be available from typo3/contrib/modalbox/modalbox.js.

#12 Updated by Christoph Koehler about 11 years ago

New patch file with corrected paths. Sorry about that.

#13 Updated by Christoph Koehler about 11 years ago

Hopefully the last version. Fixed some IE 6 and 7 issues and found it working well.

#14 Updated by Christoph Koehler almost 11 years ago

New patch, now using ExtJS. Basic functionality is the same.

#15 Updated by Jeff Segars almost 11 years ago

Added v6 of the patch that applies cleanly to trunk.

#16 Updated by Steffen Kamper almost 11 years ago

I added logout buttons and Christoph added a missing line, see patch v10

#17 Updated by Stefan Geith almost 11 years ago

Last patch (v10) doesn't work - seems it doens'thave the correct patch-format.
Could you please re-add a working patch ? Thanks !

#18 Updated by Oliver Hader over 10 years ago

Committed to SVN Trunk (rev. 4645) by Dmitry.

Also available in: Atom PDF