TYPO3 Core

Changed patch file to exclude new files and attached the new files as a .zip. They need to go into typo3/contrib.

what license is modal box?

MIT. There is a bug with IE (imagine that) that I am still trying to figure out.

MIT... so most likely it's actually X11, but this should be ok with the GPL anyways

some points about your patch:

• the class should go into typo3/classes/
• the license header is missing
• phpDoc is missing
• xclass definition is missing
• don't use tables for layout
• don't use inline html (though it is debatable here)
• the patch doesn't apply directly as it's not relative to the TYPO3 root directory (a, b at the beginning)
• include the modal box sources in the patch
• try using TYPO3's spinner, there should be one in typo3/gfx/ or so

... ok the spinner can stay, looks good.

However, I get an error as in the attached scrrenshot

Thanks, will look at those.

tables for layout: Copied and pasted the html from the current login box in index.php, but will change that.

inline html: I assume you mean the return values of the ajax methods. We can talk about that.

patch: yeah, will change that, too.

modalbox source: benni asked me to zip it since it contains binary files (the spinner)

spinner: it's included in the modalbox, i would have to change the source to switch.

hmm odd. Works fine in Safari here. Wonder if the patch is borked...

Hey Christoph,

my first remarks:

a) Your new class and all its methods does not have any comments nor License infos. Please add them.
b) Also, use PHP5 style methods (public / protected) for new functions
c) Don't echo anything directly. The AJAXObj will handle the output. Have a look at the TYPO3AJAX class and how it is used in other places in the core on how to return code as you want it.
d) Don't know if you need to urlencode this: "ajaxID=BackendLogin%3A%3AForm'

more comments:

• avoid inline css styles, put them into classes
• try to stay within 80 characters/line

Added file 9052_modal_login_2.diff with the newest changes.

I took most of the suggestions here into account.

I also changed the way that TBE_EDITOR determines a timeout. This will need some testing.
I changed jsfunc.tbe_editor.js slightly to use the busy.busyloadTime instead of the TBE EDITOR internal time, making it a little more unified.
It seems to work properly so that now, when you are editing a record and your login is timing out, once you relogin, the warning that your login expired will not show anymore.

Apply the patch and stick the files from the modalbox.zip archive into the contrib directory, so that it will be available from typo3/contrib/modalbox/modalbox.js.

New patch file with corrected paths. Sorry about that.

Hopefully the last version. Fixed some IE 6 and 7 issues and found it working well.

New patch, now using ExtJS. Basic functionality is the same.

Added v6 of the patch that applies cleanly to trunk.

I added logout buttons and Christoph added a missing line, see patch v10

Last patch (v10) doesn't work - seems it doens'thave the correct patch-format.
Could you please re-add a working patch ? Thanks !

Committed to SVN Trunk (rev. 4645) by Dmitry.