Bug #19490

RTE uses JScodeLibArray to insert CSS

Added by Jeff Segars over 11 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Category:
-
Target version:
-
Start date:
2008-10-21
Due date:
% Done:

0%

TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In tx_rtehtmlarea_base, the RTE uses $GLOBALS['SOBE']->doc->JScodeLibArray to insert CSS into the page header. This was added in revision 4298.

When using edit forms on the page in frontend editing, we don't have a true doc template and are just going through TCEForms instead. This means that adding Javascript (or CSS) through JScodeLibArray has no effect.

In bug #19485, Olly added a separate loadJavascriptLib() method for frontend editing that inserts the Javascript libraries into TSFE but that won't be the correct solution for CSS files. I'd suggest falling back to $this->TCEform->additionalCode_pre as it was in the past or adding a generic loader into TCEForms.

I'm attaching a patch that uses $this->TCEform->additionalCode_pre and works correctly in my testing in both the frontend and backend (I am seeing problems with the RTE in IRRE child records but that seems to occur with and without my patch).

(issue imported from #M9613)

009613.diff View (1.01 KB) Administrator Admin, 2008-10-21 16:26

rtehtmlarea_bugfix_9613_typo3_4-2.patch View (2.4 KB) Administrator Admin, 2008-10-22 07:08

rtehtmlarea_bugfix_9613_trunk_v3.patch View (9.93 KB) Administrator Admin, 2008-10-23 17:46


Related issues

Related to TYPO3 Core - Bug #19435: htmlARea RTE: Move link tags to head Closed 2008-10-08
Related to TYPO3 Core - Feature #19208: Additional Stylesheets in template.php Closed 2008-08-10
Related to TYPO3 Core - Bug #22330: Remove unused property $additionalStyleSheets in template.php Closed 2010-03-26

History

#1 Updated by Oliver Hader over 11 years ago

The "$GLOBALS['SOBE']->doc->JScodeLibArray['rtehtmlarea-contentCSS']" was introduced in issue #9516 and commited to SVN Trunk in rev. 4298 and TYPO3_4-2 in rev. 4297.

#2 Updated by Stanislas Rolland over 11 years ago

This attached patch will use $GLOBALS['TSFE']->additionalHeaderData when available and adds additionalHeaderData array to class template.

#3 Updated by Stanislas Rolland over 11 years ago

Committed to branch TYPO3_4-2 (revision 4347).

#4 Updated by Stanislas Rolland over 11 years ago

Committed to SVN TYPO3core trunk (revision 4350).

#5 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF