TYPO3 Core

I tried to run the script but I faced some compatibility problems on NetBSD / FreeBSD system. This is due to some little nuance betwen Linux and *BSD command.

For example this line does not work and makes the script crash.
size1=$(stat -c%s "$i")

I changed to:
size1=$(ls -al "$i" | awk '{ print $5 }')

It happens the same with: `expr index "$i" ' '` (makes the script die!)
I converted to: `/bin/expr "$i" : ".* "` I must admit I am not sure it will pass on Linux. It needs to be tested.

Btw, I have improved a little bit the script by adding a recusive handling of the images.

I prefer recursive work, too. But you should avoid `find $DIR/*` as this passes a long (often too long) argument list to find command. Use `find $DIR/` instead!

Unfortunately for me the script didn't help that much: 5% savings with 29.000 image files in typo3temp/.

Additional squizing:

- By Niels Frohling:
http://groups.google.com/group/comp.compression/browse_thread/thread/837b8aa980c3090f/e8d8cbaa213d3d68?lnk=gst&q=jpegtran#e8d8cbaa213d3d68
http://paradice-insight.us/cdb/scripts/jpeg/
- pngcrush: http://pmt.sourceforge.net/pngcrush/
- Try converting GIFs to PNGs

More info: http://developer.yahoo.com/performance/rules.html#opt_images

Here is the code...

We are adding three configuration vars to localconf.php:

$TYPO3_CONF_VARS['GFX']['jpegtran_path'] = '/usr/bin/'; // Path to jpegtran
$TYPO3_CONF_VARS['GFX']['strip_uploaded_images'] = 1; // Strip image headers from uploaded images
$TYPO3_CONF_VARS['GFX']['strip_generated_images'] = 1; // Strip image headers from Typo3 generated images (usually thumbs), ref bug #10025

In function file t3lib/class.t3lib_div.php, before function upload_copy_move:

INSERT:

public static function optimize_image($filename) {
$gfxConf = $GLOBALS['TYPO3_CONF_VARS']['GFX'];
$newfile = t3lib_div::tempnam('optimized_image_');
$path_parts = pathinfo($filename);
$extension = strtolower($path_parts['extension']);
if(in_array($extension,array('jpg','jpeg')))
$cmd = $gfxConf['jpegtran_path'] . 'jpegtran -optimize -copy none -outfile "'.$newfile.'" "'.$filename.'"';
else
$cmd = t3lib_div::imageMagickCommand('convert', '-strip "'.$filename.'" "'.$newfile.'"', $gfxConf['im_path']);
exec($cmd);
if (@is_file($newfile) && filesize($newfile)>0 && filesize($newfile)<filesize($filename))
copy($newfile,$filename);
t3lib_div::unlink_tempfile($newfile);
}

The same file, in function upload_copy_move:

BEFORE:

t3lib_div::fixPermissions($destination);

INSERT:

if($GLOBALS['TYPO3_CONF_VARS']['GFX']['strip_uploaded_images'])
t3lib_div::optimize_image($destination);

The idea is to use the same function optimize_image to process images on existing Typo3 installations within Installation Tool.

We can improve this function with pngcrush/gif2png and other stuff mentioned in this bug.

Are there any differences between this issue and #10025? Otherwise I would close this as duplicate of #10025.

#0010025 is related to

$TYPO3_CONF_VARS['GFX']['strip_generated_images'] = 1; // Strip image headers from Typo3 generated images (usually thumbs)

and this one is related to:

$TYPO3_CONF_VARS['GFX']['strip_uploaded_images'] = 1; // Strip image headers from uploaded images

so they are different things.