Project

General

Profile

Actions

Bug #21033

closed

Workspace notification emails are sent to hidden users

Added by Björn Jacob about 15 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2009-09-10
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I've hidden a backend user which is also a member of a workspace. The notification is set to "notify all users on any change".

Now another workspace member changes something within the workspace. The resulting notification email is sent to all users of the workspace even to the hidden one. IMHO the notification function should check if the respective users are hidden or not.

I've tried the same thing with deleted users. There's everything fine. Deleted users don't get any email.

(issue imported from #M11923)


Files

11923.diff (548 Bytes) 11923.diff Administrator Admin, 2009-09-14 09:38
11923_v2.diff (700 Bytes) 11923_v2.diff Administrator Admin, 2009-09-14 11:03
Actions #1

Updated by Andreas Wolf about 15 years ago

This would require a change to t3lib_TCEmain::notifyStageChange_getEmails(). At the moment it uses a call to t3lib_BEfunc::getRecord() to get user records. The check for deleted records is included there, but for hidden records we would need to include the clause returned by t3lib_BEfunc::BEenableFields().

Actions #2

Updated by Steffen Kamper about 15 years ago

fix is simple, see attached patch

Actions #3

Updated by Andreas Wolf about 15 years ago

But this only cares about hidden users - what about users with start/end-dates? E.g. if you grant access to somebody for a week to work on a part of a project - you would not want these people to get notifications after that period. So we should go for the BEenableFields() solution I proposed.

Actions #4

Updated by Steffen Kamper about 15 years ago

yes. see v2

Actions #5

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Ia2d6b94691bb5f0e68dbd32362ae4dd1610f0c59 has been pushed to the review server.
It is available at http://review.typo3.org/1540

Actions #6

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Iec2cfebb1c6d03c8761ae028f771d2d09fe6c0dc has been pushed to the review server.
It is available at http://review.typo3.org/1541

Actions #7

Updated by Susanne Moog over 13 years ago

  • Status changed from New to Under Review
  • Target version deleted (0)
Actions #8

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change Iec2cfebb1c6d03c8761ae028f771d2d09fe6c0dc has been pushed to the review server.
It is available at http://review.typo3.org/1541

Actions #9

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change Ia2d6b94691bb5f0e68dbd32362ae4dd1610f0c59 has been pushed to the review server.
It is available at http://review.typo3.org/1540

Actions #10

Updated by Michael Klapper over 13 years ago

  • Status changed from Under Review to Resolved
Actions #11

Updated by Michael Stucki almost 11 years ago

  • Category set to Workspaces
Actions #12

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #13

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF