Bug #21033
closed
Workspace notification emails are sent to hidden users
Added by Björn Jacob about 15 years ago.
Updated about 6 years ago.
Description
I've hidden a backend user which is also a member of a workspace. The notification is set to "notify all users on any change".
Now another workspace member changes something within the workspace. The resulting notification email is sent to all users of the workspace even to the hidden one. IMHO the notification function should check if the respective users are hidden or not.
I've tried the same thing with deleted users. There's everything fine. Deleted users don't get any email.
(issue imported from #M11923)
Files
This would require a change to t3lib_TCEmain::notifyStageChange_getEmails(). At the moment it uses a call to t3lib_BEfunc::getRecord() to get user records. The check for deleted records is included there, but for hidden records we would need to include the clause returned by t3lib_BEfunc::BEenableFields().
fix is simple, see attached patch
But this only cares about hidden users - what about users with start/end-dates? E.g. if you grant access to somebody for a week to work on a part of a project - you would not want these people to get notifications after that period. So we should go for the BEenableFields() solution I proposed.
Patch set 1 of change Ia2d6b94691bb5f0e68dbd32362ae4dd1610f0c59 has been pushed to the review server.
It is available at http://review.typo3.org/1540
Patch set 1 of change Iec2cfebb1c6d03c8761ae028f771d2d09fe6c0dc has been pushed to the review server.
It is available at http://review.typo3.org/1541
- Status changed from New to Under Review
- Target version deleted (
0)
Patch set 2 of change Iec2cfebb1c6d03c8761ae028f771d2d09fe6c0dc has been pushed to the review server.
It is available at http://review.typo3.org/1541
Patch set 2 of change Ia2d6b94691bb5f0e68dbd32362ae4dd1610f0c59 has been pushed to the review server.
It is available at http://review.typo3.org/1540
- Status changed from Under Review to Resolved
- Category set to Workspaces
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
- Status changed from Resolved to Closed
Also available in: Atom
PDF