TYPO3 Core

Just an Idea how this function could be improved (fullQuoteStr.diff)

Steffen Ritter:
"the function getColumns already exists in t3lib_db called admin_get_fields the task would have immense performance impact but: dbal already cached all these information (internal cache of all db fields available)
it would be an little amount of time (minutes) to move this caching from dbal to core t3lib_db with the moved cache +1"

14937_caching_*.diff patches move cache of all DB fields from DBAL to Core

14937_fullQuoteArray.diff is the patch to be used for this bug once 14937_caching_*.diff patches have been applied. This ensures that it uses cached information and as such does not "cost" anything!

Just as info, in order to test, you may omit the DBAL patch, it only moves stuff out of it...

Hi Xavier,
I'd like to give this one a bump.

By reading I have the following comments:

If I get it right, the sqlparser and the installtool is (only) needed to create the cache entries. So how about not instanciating them in the constructor, but only when needed during the caching.

Instead of reading all keys with array_keys() into a new array and then checking with in_array(), I would suggest to use arra_key_exists directly.

Other than that it looks good to me and it would be great to get this into 4.5

Patch set 2 of change I8cd0640d8f90a83f4c2104e699a597f45ec5e719 has been pushed to the review server.
It is available at http://review.typo3.org/3996

Patch set 3 of change I8cd0640d8f90a83f4c2104e699a597f45ec5e719 has been pushed to the review server.
It is available at http://review.typo3.org/3996