Feature #23051
closed
Improve t3lib_DB::fullQuoteArray
Added by Helmut Hummel over 14 years ago. Updated over 9 years ago.
0%
Description
fullQuoteArray only quotes the field values, not the field names
OTRS
2010011810000016: Sebastian Böttger
(issue imported from #M14937)
Files
| fullQuoteStr.diff (966 Bytes) fullQuoteStr.diff | Administrator Admin, 2010-06-30 10:57 | ||
| quoteFieldsInArray.diff (620 Bytes) quoteFieldsInArray.diff | Administrator Admin, 2010-06-30 14:28 | ||
| 14937_caching_core.diff (7.67 KB) 14937_caching_core.diff | Administrator Admin, 2010-07-17 16:20 | ||
| 14937_caching_dbal.diff (7.15 KB) 14937_caching_dbal.diff | Administrator Admin, 2010-07-17 16:20 | ||
| 14937_fullQuoteArray.diff (693 Bytes) 14937_fullQuoteArray.diff | Administrator Admin, 2010-07-17 16:36 |
Updated by Helmut Hummel over 14 years ago
Just an Idea how this function could be improved (fullQuoteStr.diff)
Updated by Susanne Moog over 14 years ago
Steffen Ritter:
"the function getColumns already exists in t3lib_db called admin_get_fields the task would have immense performance impact but: dbal already cached all these information (internal cache of all db fields available)
it would be an little amount of time (minutes) to move this caching from dbal to core t3lib_db with the moved cache +1"
Updated by Xavier Perseguers over 14 years ago
14937_caching_*.diff patches move cache of all DB fields from DBAL to Core
Updated by Xavier Perseguers over 14 years ago
14937_fullQuoteArray.diff is the patch to be used for this bug once 14937_caching_*.diff patches have been applied. This ensures that it uses cached information and as such does not "cost" anything!
Updated by Xavier Perseguers over 14 years ago
Just as info, in order to test, you may omit the DBAL patch, it only moves stuff out of it...
Updated by Helmut Hummel almost 14 years ago
Hi Xavier,
I'd like to give this one a bump.
By reading I have the following comments:
If I get it right, the sqlparser and the installtool is (only) needed to create the cache entries. So how about not instanciating them in the constructor, but only when needed during the caching.
Instead of reading all keys with array_keys() into a new array and then checking with in_array(), I would suggest to use arra_key_exists directly.
Other than that it looks good to me and it would be great to get this into 4.5
Updated by Michael Stucki over 13 years ago
- Target version deleted (
4.6.0-beta1)
Updated by Helmut Hummel over 13 years ago
- Project changed from 1716 to TYPO3 Core
Updated by Mr. Hudson over 13 years ago
Patch set 2 of change I8cd0640d8f90a83f4c2104e699a597f45ec5e719 has been pushed to the review server.
It is available at http://review.typo3.org/3996
Updated by Mr. Hudson over 13 years ago
Patch set 3 of change I8cd0640d8f90a83f4c2104e699a597f45ec5e719 has been pushed to the review server.
It is available at http://review.typo3.org/3996
Updated by Gerrit Code Review almost 13 years ago
- Status changed from Accepted to Under Review
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/3996
Updated by Alexander Opitz over 11 years ago
- Status changed from Under Review to New
Patch was postponed
Updated by Mathias Schreiber almost 10 years ago
- Target version set to 7.4 (Backend)
Updated by Helmut Hummel almost 10 years ago
- Assignee deleted (
Helmut Hummel)
Will not work on this any more. Feel free to close or take over
Updated by Susanne Moog over 9 years ago
- Target version changed from 7.4 (Backend) to 7.5
Updated by Helmut Hummel over 9 years ago
- Status changed from New to Rejected
Imho this is not worth the hassle. We cannot automate much here in this lowlevel method.