Project

General

Profile

Actions
Copy link

Task #25024

closed

Remove typo3/gfx

Added by Steffen Kamper almost 14 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
7.5
Start date:
2011-02-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

These images are not used any longer. Also they are duplicated in sysext/t3skin/icons/gfx. Those which are missing there could be copied
to this place.
A rewrite rule in htaccess could be the backwards compatible way if
anyone refers direct to the old resources.

(issue imported from #M17569)

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Task #31461: The Big Cleanup 4.7Closed2012-02-192012-02-20

Actions
Blocked by TYPO3 Core - Bug #24920: feedit does not use t3lib_iconWorks::SkinImage for edit iconsClosed2011-02-01

Actions
Actions
Copy link
 #1

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I735f00af0c52d36f27fafa99c7c311f0969b16e9 has been pushed to the review server.
It is available at http://review.typo3.org/1985

Actions
Copy link
 #2

Updated by Xavier Perseguers over 13 years ago

  • Status changed from New to Under Review
  • TYPO3 Version changed from 4.5 to 4.6
Actions
Copy link
 #3

Updated by Xavier Perseguers over 13 years ago

  • Tracker changed from Bug to Task
Actions
Copy link
 #4

Updated by Xavier Perseguers over 13 years ago

  • Target version changed from 1081 to 1238
Actions
Copy link
 #5

Updated by Xavier Perseguers over 13 years ago

What would be the proper way for deprecating their use?

Actions
Copy link
 #6

Updated by Georg Ringer over 13 years ago

htaccess to an ajax call to be able to log the call?

Actions
Copy link
 #7

Updated by Georg Ringer over 13 years ago

again: IMO this is a no go to just remove things in core. Everything is deprecated and so must also be the icons.

i searched for typo3/gfx/ and IMO the admin panel uses it:

$outTable.= '<tr>' .
                        '<td style="white-space:nowrap;"><img src="typo3/gfx/clear.gif" width="' . (($depth + 1 - $row[2]) * 18) . '" height="1" alt="" /><img ' .
                        t3lib_iconWorks::skinImg(TYPO3_mainDir, 'gfx/i/pages.gif', 'width="18" height="16"') . ' align="top" border="0" alt="" />' . $row[1] .
                        '</td><td><img src="typo3/gfx/clear.gif" width="10" height="1" alt="" /></td><td>...</td></tr>';

and install tool
} else die('No typo3/gfx/typo3logo.gif file!');

and statictemplates uses it in a sql insert.

furthermore: did you do a check if all icons are available in t3skin? IMO there is a fallback from there to typo3/gfx/?

Actions
Copy link
 #8

Updated by Oliver Hader over 13 years ago

  • Target version changed from 1238 to 1281
Actions
Copy link
 #9

Updated by Thorsten Kahler over 13 years ago

If the files are still in use, we can change that.

As with any other stuff IMHO we have a deprecation for those files also, don't we? So redirecting via an (optional) logger script might be a valid step before removing the files without proper compensation.

Actions
Copy link
 #10

Updated by Xavier Perseguers over 13 years ago

  • Target version changed from 1281 to 4.6.0-beta1
Actions
Copy link
 #11

Updated by Xavier Perseguers over 13 years ago

  • Priority changed from Should have to Must have
Actions
Copy link
 #12

Updated by Xavier Perseguers over 13 years ago

  • Target version deleted (4.6.0-beta1)
Actions
Copy link
 #13

Updated by Xavier Perseguers about 13 years ago

  • Status changed from Under Review to New
  • Priority changed from Must have to Should have
  • TYPO3 Version changed from 4.6 to 4.7
Actions
Copy link
 #14

Updated by Felix Kopp over 11 years ago

Anything new? How can the unused icons be identified?

gfx/selicons

are used for example when t3skin is inactive.

Actions
Copy link
 #15

Updated by Riccardo De Contardi almost 10 years ago

Searching for "typo3/gfx" inside TYPO3 6.2.9 core brings the following results:

/typo3/sysext/css_styled_content/static/setup.txt
/typo3/sysext/css_styled_content/static/v6.0/setup.txt
/typo3/sysext/css_styled_content/static/v6.1/setup.txt
/typo3/sysext/frontend/Classes/View/AdminPanelView.php
/typo3/sysext/indexed_search/Classes/Controller/SearchController.php
/typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php

Actions
Copy link
 #16

Updated by Riccardo De Contardi over 9 years ago

same search, results for:

1. TYPO3 6.2.13:

/ChangeLog
/typo3/sysext/css_styled_content/static/setup.txt
/typo3/sysext/css_styled_content/static/v6.0/setup.txt
/typo3/sysext/css_styled_content/static/v6.1/setup.txt
/typo3/sysext/frontend/Classes/View/AdminPanelView.php
/typo3/sysext/indexed_search/Classes/Controller/SearchController.php
/typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php

2. TYPO3 7 (latest master):

/ChangeLog
/typo3/sysext/core/Documentation/Changelog/7.1/Breaking-64143-FlagFilesMoved.rst
/typo3/sysext/core/Documentation/Changelog/7.1/Breaking-64143-FlagFilesMoved.rst
/typo3/sysext/core/Documentation/Changelog/7.1/Breaking-64143-FlagFilesMoved.rst
/typo3/sysext/frontend/Classes/View/AdminPanelView.php
Actions
Copy link
 #17

Updated by Wouter Wolters over 9 years ago

There are many more places where images are still used from this folder.
For example I wrote https://review.typo3.org/#/c/40660/ that moves a few images

Actions
Copy link
 #18

Updated by Benni Mack over 9 years ago

  • Target version set to 7.4 (Backend)
  • Sprint Focus set to Stabilization Sprint
Actions
Copy link
 #19

Updated by Wouter Wolters over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
  • Sprint Focus deleted (Stabilization Sprint)

Let's kick this in 7.5..

Actions
Copy link
 #20

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42299

Actions
Copy link
 #21

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42299

Actions
Copy link
 #22

Updated by Benni Mack over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #23

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF