Project

General

Profile

Actions

Feature #25112

closed

Deprecate select.andWhere

Added by Marc Bastian Heinrichs almost 14 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-02-20
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

As written in #22338 'andWhere' can become deprecated, because the only reason for its existence was stdWrap support.

(issue imported from #M17681)

Actions #1

Updated by Andreas Kießling over 13 years ago

Deprecating it now would mean, it would be removed with 4.8?
My fear is: "a lot of sites wil be upgraded to 4.5" ;)
With LTS, you will probably stick to 4.5 until support ends, because that is what LTS is for. Right?
Once you "have to" upgrade, you won't see any entry in the deprecation log. The property is gone and your TS just does not work anymore...

Actions #2

Updated by Björn Pedersen over 13 years ago

It is still used in trunk TS for menu type: section index.

Actions #3

Updated by Dmitry Dulepov over 13 years ago

-1.

It is useful because you may have a general TS object with "where" and TS objects based on it that add various conditions using "andWhere".

Actions #4

Updated by Marc Bastian Heinrichs over 13 years ago

I opened this issue to have the comment from #22338 in mind deprecating andWhere.

It's okay for my me to keep this, but then andWhere should also support the markers introduced in #22338 to prevent SQL injection problems.

Actions #5

Updated by Alexander Opitz about 10 years ago

  • Description updated (diff)
  • Status changed from New to Needs Feedback
  • Target version deleted (0)

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.4)?

Actions #6

Updated by Marc Bastian Heinrichs almost 10 years ago

  • Status changed from Needs Feedback to New

andWhere is still there http://docs.typo3.org/typo3cms/TyposcriptReference/Functions/Select/Index.html
and IMO should still be removed

Actions #7

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35800

Actions #8

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35800

Actions #9

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35800

Actions #10

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35800

Actions #11

Updated by Georg Ringer almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Chris topher over 9 years ago

Marc Bastian Heinrichs wrote:

andWhere is still there http://docs.typo3.org/typo3cms/TyposcriptReference/Functions/Select/Index.html
and IMO should still be removed

Fixed in current master.

Actions #13

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF