Feature #25112

Deprecate select.andWhere

Added by Marc Bastian Heinrichs over 8 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-02-20
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

As written in #22338 'andWhere' can become deprecated, because the only reason for its existence was stdWrap support.

(issue imported from #M17681)

Associated revisions

Revision 7b83b959 (diff)
Added by Georg Ringer over 4 years ago

[TASK] Deprecate TS property andWhere

As the property "where" got full stdWrap support, there is no
need to keep "andWhere".

Resolves: #25112
Releases: master
Change-Id: Iffe166047d022508e2808e681f3693859bc58041
Reviewed-on: http://review.typo3.org/35800
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Andreas Kiessling about 8 years ago

Deprecating it now would mean, it would be removed with 4.8?
My fear is: "a lot of sites wil be upgraded to 4.5" ;)
With LTS, you will probably stick to 4.5 until support ends, because that is what LTS is for. Right?
Once you "have to" upgrade, you won't see any entry in the deprecation log. The property is gone and your TS just does not work anymore...

#2 Updated by Björn Pedersen about 8 years ago

It is still used in trunk TS for menu type: section index.

#3 Updated by Dmitry Dulepov about 8 years ago

-1.

It is useful because you may have a general TS object with "where" and TS objects based on it that add various conditions using "andWhere".

#4 Updated by Marc Bastian Heinrichs about 8 years ago

I opened this issue to have the comment from #22338 in mind deprecating andWhere.

It's okay for my me to keep this, but then andWhere should also support the markers introduced in #22338 to prevent SQL injection problems.

#5 Updated by Alexander Opitz over 4 years ago

  • Description updated (diff)
  • Status changed from New to Needs Feedback
  • Target version deleted (0)

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.4)?

#6 Updated by Marc Bastian Heinrichs over 4 years ago

  • Status changed from Needs Feedback to New

andWhere is still there http://docs.typo3.org/typo3cms/TyposcriptReference/Functions/Select/Index.html
and IMO should still be removed

#7 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35800

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35800

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35800

#10 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35800

#11 Updated by Georg Ringer over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Chris topher about 4 years ago

Marc Bastian Heinrichs wrote:

andWhere is still there http://docs.typo3.org/typo3cms/TyposcriptReference/Functions/Select/Index.html
and IMO should still be removed

Fixed in current master.

#13 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF