Bug #25387
closedInstallation from own TER not possible
Added by Christian Weiske over 13 years ago. Updated over 11 years ago.
100%
Description
I setup an own TER and used the extension manager to upload an extension to it - that worked fine.
It is possible to search the extension in my own TER using the extension manager, but importing it fails. The reason is that the EM tries to fetch the extension file from one of the orginal TYPO3 extension repository mirrors, and not from the custom one (although I have an own mirrors.xml defined and loaded).
The probable cause is that
typo3/sysext/em/classes/index.php::importExtFromRep()
does not care about the selected repository at all.
(issue imported from #M18028)
Files
25387.patch (2.76 KB) 25387.patch | Steffen Kamper, 2011-03-30 01:35 |
Updated by Christian Weiske over 13 years ago
The translation files have the same issue. When checking for translations, only the main repository is asked and not the custom TER.
Updated by Steffen Kamper over 13 years ago
could you send me a mail with your ter adresses for testing the issue?
info@sk-typo3.de
Updated by Christian Weiske over 13 years ago
The TER is only available internally, but I'll setup a public one.
Updated by Christian Weiske over 13 years ago
I setup a demo TER at http://terdemo.netresearch.de/
You can add it to your extension manager with the following data:- Mirror URL: http://terdemo.netresearch.de/fileadmin/mirrors.xml
- WSDL URL: http://terdemo.netresearch.de/wsdl/tx_ter_wsdl.php
There is one single extension in it; nr_coremetrics.
Updated by Steffen Kamper over 13 years ago
- File 25387.patch 25387.patch added
- Target version set to 4.5.3
- % Done changed from 0 to 100
Updated by Steffen Kamper over 13 years ago
- Status changed from Accepted to Under Review
Updated by Christian Weiske over 13 years ago
Importing extensions from the own repository works now with the patch, but not anymore from the original typo3 repository - this may be the same problem as I described in bug #25390.
Updated by Ernesto Baschny about 13 years ago
I confirm the behaviour observed by Christian in the last comment regarding the currently being reviewed change in gerrit:
Even switching to the Main Repository will still try to connect to the second repository, you can notice that also by the missing icons in front of the extensions (as they are tried to be fetched from the wrong repository).
The problem is that in the code the patch is referring to "$settings['selectedRepository']", which is the repository selected in the "Settings" tab, whereas in the "Remote Repository" tab there is a different (independent) repository selector.
So fetching only works if the second repository is set in the "Settings" tab (after the patch).
Updated by Mr. Hudson about 13 years ago
Patch set 2 of change Id50652b19b85f85c3156f031b53ad84fbd671de6 has been pushed to the review server.
It is available at http://review.typo3.org/1318
Updated by Mr. Hudson about 13 years ago
Patch set 3 of change Id50652b19b85f85c3156f031b53ad84fbd671de6 has been pushed to the review server.
It is available at http://review.typo3.org/1318
Updated by Mr. Hudson about 13 years ago
Patch set 2 of change Ib699d26a6a2731df4eece71712244e067e85db03 has been pushed to the review server.
It is available at http://review.typo3.org/1319
Updated by Oliver Hader about 13 years ago
- Target version changed from 4.5.3 to 4.5.4
Updated by Oliver Hader about 13 years ago
- Target version changed from 4.5.4 to 4.5.6
Updated by Mr. Hudson almost 13 years ago
Patch set 4 of change Id50652b19b85f85c3156f031b53ad84fbd671de6 has been pushed to the review server.
It is available at http://review.typo3.org/1318
Updated by Mr. Hudson almost 13 years ago
Patch set 5 of change Id50652b19b85f85c3156f031b53ad84fbd671de6 has been pushed to the review server.
It is available at http://review.typo3.org/1318
Updated by Mr. Hudson almost 13 years ago
Patch set 6 of change Id50652b19b85f85c3156f031b53ad84fbd671de6 has been pushed to the review server.
It is available at http://review.typo3.org/1318
Updated by Chris topher almost 13 years ago
- Target version changed from 4.5.6 to 4.5.8
Updated by Gerrit Code Review over 12 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/1318
Updated by Ernesto Baschny over 12 years ago
- Target version changed from 4.5.8 to 4.5.12
Updated by Xavier Perseguers over 12 years ago
- Assignee deleted (
Steffen Kamper)
Updated by Gerrit Code Review over 12 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/1318
Updated by Wouter Wolters over 12 years ago
I setup a demo TER at http://terdemo.wind-ontwikkeling.nl/
You can add it to your extension manager with the following data:
Mirror URL: http://terdemo.wind-ontwikkeling.nl/fileadmin/mirrors.xml.gz
WSDL URL: http://terdemo.wind-ontwikkeling.nl/wsdl/tx_ter_wsdl.php
There is one single extension in it; pmkttnewstwitter.
In this extension I changed the author to "Test" to see the difference.
Updated by Gerrit Code Review over 12 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/1318
Updated by Gerrit Code Review over 12 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/1318
Updated by Christian Weiske about 12 years ago
I just tried patch set 10 with the terdemo.wind-ontwikkeling.nl repository and have to say that searching for extensions in the main repository does not work anymore.
Steps to reproduce:
1. Fresh typo3 install
2. Log into typo3 backend, extension manager
3. Create new repository in the settings tab
4. On the "Import extensions" tab, select the new repository and update it
5. Also select the main repository and update it
6. Search for "p"
7. Only one extension will be shown; the one from the new test repository.
So it does not really work :/
Updated by Wouter Wolters about 12 years ago
Christian, that is another bug in the extension manager. The repository in the import tab and the settings are saved in the same value. When you select it correct in the settings tab and in the import tab you are able to search in the Main repository again. This bug is not fixed by this patch. The code for this is hard and AFAIK for 6.0 there will be a new Extension Manager.
Updated by Christian Weiske about 12 years ago
Ok, importing the extension works for me now for both repositories - the main repository and the wind repository!
Updated by Ernesto Baschny about 12 years ago
I also wasn't able to reproduce the working. The explanation of how to reproduce is fantastic, thanks! But unfortunately it keeps downloading the extension from the main repo (I see no "Test" in ext_emconf.php) no matter how "hard" I choose the Test Repo (either through the Settings or through the select box in the Import Extensions Tab.
Can you verify that it works on your setup?
This needs to be backported to 4.5 as soon as it is fixed and working, because else the "own repository" feature doesn't make sense.
Updated by Wouter Wolters about 12 years ago
I can still verify that this is working on master. Just tested with 2 repositories other then the main repository.
I just enable an extra Repository and I update the new repository and then I can download. Switching back to the main and searching for an extension and downloading is also still working.
To be really sure I opened another connection and were able to switch between those three repositories.
Updated by Christian Weiske about 12 years ago
@Ernesto: You need to work around the repository selection bug. Do that:
- Fresh typo3 installation with the patch for this issue from gerrit
- Log into typo3 backend, extension manager
- Create new repository in the settings tab
- On the "Import extensions" tab, select the new repository and update it
- Also select the main repository and update it
- Search for "p". Extensions from the main repository will be shown.
- Switch the dropdown to the wind repository. The pmkttnewstwitter extension will be shown
- Click on the import icon
- Popup will be shown: The extension has been imported
- Now try an extension from the main repository: Go to the import tab.
- Switch the dropdown to the main repository
- Search for "news"
- Import extension
- Popup will be shown: The extension has been imported
Updated by Christian Weiske about 12 years ago
@Wouter: Did I understand you correctly saying that typo3 git master works fine without this patch?
I cannot confirm that; typo3 git master without any patch does not even let me update the repository. With the patch, it works.
Updated by Christian Kuhn over 11 years ago
- Status changed from Under Review to Rejected
Rejected: This will not be implemented in 4.5, 4.6, 4.7 anymore. This might be a feature for new 6.0 em, but I wouldn't spent too much time on that, too (this will probably solve itself if we manage to implement clean composer support for 6.1)