Bug #26901

Icon for new page should be hidden if no access to pages

Added by Georg Ringer over 10 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
Start date:
2011-05-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.5
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If an user doesn't have any access to pages records, he shouldn't even see the icon above the tree.

moreover: if trying to add a page, the error is wrong as it says "Exception
[1.2.1]: Attempt to modify table '%s' without permission". so the %s is not substituted.


Related issues

Related to TYPO3 Core - Bug #25433: Pagetree drag and drop - should be disabled when user can not edit "pages"Closed2011-03-29

Actions
Related to TYPO3 Core - Feature #13265: Make new pages toolbar open by default in the page treeClosedPaweĊ‚ Rogowicz2011-02-22

Actions
#1

Updated by Alexander Opitz over 7 years ago

  • Status changed from New to Needs Feedback
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.4)?

#2

Updated by Stefan Neufeind over 7 years ago

  • Status changed from Needs Feedback to Accepted

With master (pre-6.3) it sort-of still exists. Above the tree the user still has a "new"-icon. When clicking on that the toolbar of available page-types to create would usually show up. That toolbar is empty. But still it's irritating to have that icon there if you don't have rights to create a page.

#3

Updated by Daniel Goerz over 6 years ago

  • Target version set to 7 LTS
  • TYPO3 Version changed from 4.6 to 7
  • PHP Version changed from 5.3 to 5.5
#4

Updated by Daniel Goerz over 6 years ago

  • Assignee set to Daniel Goerz
#5

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43629

#6

Updated by Daniel Goerz over 6 years ago

How to reproduce/test:

  1. Create a Backend User Group
  2. Dont grant Right to Create any Doktype
  3. Assign Group to non-admin BE-User
  4. Login with that user

This solution has the tiny flaw, that the Icon now appears not until the AJAX Call has finished and is not visible for the duration of the call. This was however imho preferable to showing the icon always and make it disappear if no rights are granted, as users are familiar with stuff being loaded asynchronously rather than stuff disappearing. Additionally the toolbar is empty as well for the duration of the AJAX call.

#7

Updated by Daniel Goerz over 6 years ago

Regarding #13265 it is questionable if we need that button at all. Opinions?

#8

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43629

#9

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43629

#10

Updated by Daniel Goerz over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Riccardo De Contardi over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF