Project

General

Profile

Actions
Copy link

Feature #28699

closed

Graphicsmagick User Command

Added by Carsten Bleicker over 13 years ago. Updated over 5 years ago.

Status:
Rejected
Priority:
Could have
Assignee:
-
Category:
Image Generation / GIFBUILDER
Target version:
-
Start date:
2011-08-03
Due date:
% Done:

0%

Estimated time:
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

i cant find a way to place my own user command to gifbuilder->graphicsmagick.
so i wrote just 3 lines in t3lib_stdGraphic::IMparams() after all other cases:

function IMparams($setup) {
....
case 'user':
$commands .= ' ' . $value;
break;
}

with this i can produce duplex (sepia) images via ts like:
page.10 = IMAGE
page.10.file = GIFBUILDER
page.10.file {

XY = [10.w],[10.h]
10 = IMAGE
  10.file = fileadmin/1.jpg
20 = EFFECT
  30.value = user = -colorspace RGB -modulate 130,0,100 -colorize 100/70/0/10

}

maybe this is a way to support full functions of graphicsmagick an not only predefined?
or is there another way to place my own commands?

kind regards
carsten

Actions
Copy link
 #1

Updated by Carsten Bleicker over 13 years ago

sorry, has to be:
20 = EFFECT
20.value = user = -colorspace RGB -modulate 130,0,100 -colorize 100/70/0/10

Actions
Copy link
 #2

Updated by Björn Pedersen over 13 years ago

Could be nice, but needs some checks to prevent execution of arbitrary shell commands!

Actions
Copy link
 #3

Updated by Carsten Bleicker over 13 years ago

Björn Pedersen wrote:

Could be nice, but needs some checks to prevent execution of arbitrary shell commands!

yep, didnt keep any mind in security at this point :)
just want discuss it.

but ts should be allways admin feature. dont know, is there any chance to "hack" it without ts access?

another idea:
does it make sense to put stdWrap support for this "user command"?

Actions
Copy link
 #4

Updated by Jigal van Hemert over 13 years ago

  • Status changed from New to Needs Feedback

The gifbuilder object SCALE has a 'params' property which allows you to send parameters to ImageMagick / GraphicsMagick.

Is this enough for you?

Actions
Copy link
 #5

Updated by Carsten Bleicker over 13 years ago

didn't check this but it is confusing to send a colorspace option in a scale object, isn't it?

Actions
Copy link
 #6

Updated by Alexander Opitz over 11 years ago

  • Status changed from Needs Feedback to New
Actions
Copy link
 #7

Updated by Mathias Schreiber almost 10 years ago

  • Target version set to 7.2 (Frontend)
Actions
Copy link
 #8

Updated by Benni Mack over 9 years ago

  • Target version changed from 7.2 (Frontend) to 7.4 (Backend)
Actions
Copy link
 #9

Updated by Susanne Moog over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions
Copy link
 #10

Updated by Benni Mack about 9 years ago

  • Target version deleted (7.5)
Actions
Copy link
 #11

Updated by Susanne Moog about 7 years ago

  • Category changed from Image Cropping to Image Generation / GIFBUILDER
Actions
Copy link
 #12

Updated by Benni Mack over 5 years ago

  • Status changed from New to Rejected

sry. won't do due to critical injection possiblity via TypoScript.

Actions
Copy link

Also available in: Atom PDF