Project

General

Profile

Actions
Copy link

Bug #29220

closed

createEncryptionKey always returns key with 96 characters

Added by Adrian Rochau over 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Helmut Hummel
Category:
Backend API
Target version:
-
Start date:
2011-08-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

In file introductionpackage-4.5.4\typo3\sysext\install\mod\class.tx_install.php in function createEncryptionKey a parameter $keyLength can be set but is ignored in the end.

Since bin2hex returns two characters for each byte the following version should be sufficient.

Instead of:

public function createEncryptionKey($keyLength = 96) {
    $bytes = t3lib_div::generateRandomBytes($keyLength);
    return substr(bin2hex($bytes), -96);
}

Use:

public function createEncryptionKey($keyLength = 96) {
    $bytes = t3lib_div::generateRandomBytes(ceil($keyLength/2));
    return substr(bin2hex($bytes), $keyLength);
}

Actions
Copy link

Also available in: Atom PDF