TYPO3 Core

Steffen Gebert wrote:

Got broken with 5dc1ab28 (a follow-up for #15741) while copy and pasting (wtf..)

Jens, could you please point out, how to reproduce the bug? At least code-wise it looks obvious.

Okay, I had a look at the diff files and saw that you have changed the behavior of this function.
But. If you do so $labelPattern and the call off preg_replace are useless and even the parameter $stripFromSelectionName is useless and irritating. So its better to remove it, i think.
I prefer the old behaviour.
Jens

Steffen Gebert wrote:

Got broken with 5dc1ab28 (a follow-up for #15741) while copy and pasting (wtf..)

Jens, could you please point out, how to reproduce the bug? At least code-wise it looks obvious.

In your Testfile (t3lib_pagerendererTest.php) is the Testcase
$this->assertContains('edRecord', $out);
in the function
"areInlineLanguageLablesSelectedAndStripped() (line 844)"
wrong

it must be $this->assertNotContains('lock', $out);

if you will see that the string is stripped.

Jens

In TYPO3 CMS 6.2.11 the only occurences of the string "$labelsFromFile[$label]" are in the file

/typo3/sysext/core/Classes/Page/PageRenderer.php, lines 2579 and 2582:

foreach ($labels as $label => $value) {
    if ($selectionPrefix === '') {
        $labelsFromFile[$label] = $value;
    } elseif (strpos($label, $selectionPrefix) === 0) {
        preg_replace($labelPattern, '', $label);
        $labelsFromFile[$label] = $value;
    }
}

still present in 7 (latest master), same file, lines 2572 and 2575

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42201

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42201

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42201