TYPO3 Core

Hi Bjoern!

Do you mind sending this as an actual change request to gerrit?
If you need help, just let us know.

Thank you, Markus

Hi Markus,

I've never used Gerrit. Could you please send me a how-to? If you can tell me how to send this change request I'll try to handle it ;)

There's something wrong with my code. $gfxConf['im_jpg_quality'] is not definded. Here's the working code:

$cmd = t3lib_div::imageMagickCommand('combine', '-compose over -quality '.intval($GLOBALS['TYPO3_CONF_VARS']['GFX']['jpg_quality']).' +matte ' . $this->wrapFileName($input) . ' ' . $this->wrapFileName($overlay) . ' ' . $this->wrapFileName($theMask) . ' ' . $this->wrapFileName($output)); // +matte = no alpha layer in output

This issue is freaking old. We'll have to check if it's still an issue and send if applicable a change request.

I guess it is still present on 8.5.0-dev; I've seen that in the file typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php the code:

public function combineExec($input, $overlay, $mask, $output)
    {
        if ($this->NO_IMAGE_MAGICK) {
            return '';
        }
        $theMask = $this->randomName() . '.' . $this->gifExtension;
        // +matte = no alpha layer in output
        $this->imageMagickExec($mask, $theMask, '-colorspace GRAY +matte');

        $parameters = '-compose over +matte '
                      . CommandUtility::escapeShellArgument($input) . ' '
                      . CommandUtility::escapeShellArgument($overlay) . ' '
                      . CommandUtility::escapeShellArgument($theMask) . ' '
                      . CommandUtility::escapeShellArgument($output);
        $cmd = CommandUtility::imageMagickCommand('combine', $parameters);
        $this->IM_commands[] = [$output, $cmd];
        $ret = CommandUtility::exec($cmd);
        // Change the permissions of the file
        GeneralUtility::fixPermissions($output);
        if (is_file($theMask)) {
            @unlink($theMask);
        }
        return $ret;
    }

the quality parameter is absent (AFAICS)

Hi Björn,

by now you should be able to submit a patch to gerrit - but I took care of it for you in the meantime ;) - Thanks for making TYPO3 better.

Let me know if the patch works for you!

All the best,
Benni.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60464

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60478