TYPO3 Core

Hello there

I as promised I made a patch and here is how it works:

New Version of Tx_Extbase_Persistence_Storage_Typo3DbBackend::parseOrderings

    /**
     * Transforms orderings into SQL.
     *
     * @param array $orderings An array of orderings (Tx_Extbase_Persistence_QOM_Ordering)
     * @param Tx_Extbase_Persistence_QOM_SourceInterface $source The source
     * @param array &$sql The query parts
     * @return void
     */
    protected function parseOrderings(array $orderings, Tx_Extbase_Persistence_QOM_SourceInterface $source, array &$sql) {
        foreach ($orderings as $propertyName => $order) {
            switch ($order) {
                case Tx_Extbase_Persistence_QOM_QueryObjectModelConstantsInterface::JCR_ORDER_ASCENDING: // Deprecated since Extbase 1.1
                case Tx_Extbase_Persistence_QueryInterface::ORDER_ASCENDING:
                    $order = 'ASC';
                    break;
                case Tx_Extbase_Persistence_QOM_QueryObjectModelConstantsInterface::JCR_ORDER_DESCENDING: // Deprecated since Extbase 1.1
                case Tx_Extbase_Persistence_QueryInterface::ORDER_DESCENDING:
                    $order = 'DESC';
                    break;
                default:
                    throw new Tx_Extbase_Persistence_Exception_UnsupportedOrder('Unsupported order encountered.', 1242816074);
            }
            if ($source instanceof Tx_Extbase_Persistence_QOM_SelectorInterface) {
                $className = $source->getNodeTypeName();
                $tableName = $this->dataMapper->convertClassNameToTableName($className);
                while (strpos($propertyName, '.') !== FALSE) {
                    $this->addUnionStatement($className, $tableName, $propertyName, $sql);
                }
            } elseif ($source instanceof Tx_Extbase_Persistence_QOM_JoinInterface) {
                $tableName = $source->getLeft()->getSelectorName();
            }

            $aConcatFields = array();
            if(preg_match('/(concat)\(([^)]*)\)\s*as\s+([^\s]+)/i', $propertyName, $aConcatFields)) {
                $currentTable = $sql['fields'];

                // just get the first table name to simulate a proper table field
                foreach($currentTable as $table => $fields) {
                    $sql['fields'][$table] = $fields . ',' . $aConcatFields[1] . '('.$aConcatFields[2].') as ' . $aConcatFields[3];
                }
                // $sql['fields'] = $aConcatFields[1] . '('.$aConcatFields[3].') as ' . $aConcatFields[4];
                $columnName = $aConcatFields[3];

                $tableName = '';

            } else {
                $columnName = $this->dataMapper->convertPropertyNameToColumnName($propertyName, $className);
            }

            if (strlen($tableName) > 0) {
                $sql['orderings'][] = $tableName . '.' . $columnName . ' ' . $order;
            } else {
                $sql['orderings'][] = $columnName . ' ' . $order;
            }
        }
    }

The counting method has to be modified as well (Tx_Extbase_Persistence_Storage_Typo3DbBackend::getObjectCountByQuery):

    /**
     * Returns the number of tuples matching the query.
     *
     * @param Tx_Extbase_Persistence_QOM_QueryObjectModelInterface $query
     * @return integer The number of matching tuples
     */
    public function getObjectCountByQuery(Tx_Extbase_Persistence_QueryInterface $query) {
        $constraint = $query->getConstraint();
        if($constraint instanceof Tx_Extbase_Persistence_QOM_StatementInterface) {
            throw new Tx_Extbase_Persistence_Storage_Exception_BadConstraint('Could not execute count on queries with a constraint of type Tx_Extbase_Persistence_QOM_StatementInterface', 1256661045);
        }
        $parameters = array();
        $statementParts = $this->parseQuery($query, $parameters);
        // if limit is set, we need to count the rows "manually" as COUNT(*) ignores LIMIT constraints
        if (!empty($statementParts['limit'])) {
            $statement = $this->buildQuery($statementParts, $parameters);
            $this->replacePlaceholders($statement, $parameters);
            $result = $this->databaseHandle->sql_query($statement);
            $this->checkSqlErrors($statement);
            $count = $this->databaseHandle->sql_num_rows($result);
        } else {
            $statementParts['fields'] = array('COUNT(*)');
            // Backup the ordering statement
            $oderings = $statementParts['orderings'];
            // remove it since for count we do not need any ordering
            $statementParts['orderings'] = null;
            // make the query
            $statement = $this->buildQuery($statementParts, $parameters);
            // put back the orderings to the statemet parts
            $statementParts['orderings'] = $orderings;
            unset($orderings);
            $this->replacePlaceholders($statement, $parameters);
            $result = $this->databaseHandle->sql_query($statement);
            $this->checkSqlErrors($statement);
            $rows = $this->getRowsFromResult($query->getSource(), $result);
            $count = current(current($rows));
        }
        $this->databaseHandle->sql_free_result($result);
        return $count;
    }

Greetings Tizian

Hi,

was this issue fixed or does it still exists?

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61443