Project

General

Profile

Actions

Task #32758

closed

Cache result of JS and CSS file concatenation

Added by Steffen Gebert almost 13 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend API
Target version:
Start date:
2011-12-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.5
Tags:
Complexity:
Sprint Focus:

Description

Concatenating the JS and CSS files (esp. in BE) is very expensive (up to 6% of rendering time).

Even more expensive than checking for file modifications is are the string operations while figuring out, what to include (resolveBackPath, isValidPath etc.).

So to be precise: Of course, we do not concatenate it every time. It's only about figuring out, how the hash of the concatenated file is (this is based on the included file names and their modification times - and this is already expensive).


Files

32758.diff (1.95 KB) 32758.diff Steffen Gebert, 2011-12-21 19:03

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #75127: Performance problem compress/concatenate CSS/JSClosed2016-03-15

Actions
Actions #1

Updated by Steffen Gebert almost 13 years ago

Preliminary patch attached. Tricky parts missing: Cache clearing (on extension installation, what else?) and consequences for FE?

Actions #2

Updated by Markus Klein almost 13 years ago

Shouldn't the *worker() functions be static?

Actions #3

Updated by Steffen Gebert almost 13 years ago

Ah, no ;) I shouldn't call them statically ;)

Used the same approach to tune some other code in t3lib_div, that's why my brain was so static ;)

Actions #4

Updated by Mathias Schreiber almost 10 years ago

  • Category changed from Miscellaneous to Backend API
  • Status changed from New to Accepted
  • Assignee set to Jigal van Hemert
  • Priority changed from Could have to Should have
  • Target version set to 7.0
  • PHP Version set to 5.5

@Jigal van Hemert,

can you check this in connection to the CSS-Splitter you added earlier?

Actions #5

Updated by Mathias Schreiber almost 10 years ago

  • Target version changed from 7.0 to 7.1 (Cleanup)
Actions #6

Updated by Benni Mack over 9 years ago

  • Target version changed from 7.1 (Cleanup) to 7.4 (Backend)
Actions #7

Updated by Susanne Moog over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #8

Updated by Benni Mack about 9 years ago

  • Target version changed from 7.5 to 7 LTS
Actions #9

Updated by Benni Mack about 9 years ago

  • Tracker changed from Feature to Task
Actions #10

Updated by Susanne Moog over 5 years ago

  • Status changed from Accepted to Needs Feedback
  • TYPO3 Version set to 4.5

@Jigal van Hemert Are you still working on this? Is the issue still valid?

Actions #11

Updated by Susanne Moog over 4 years ago

  • Status changed from Needs Feedback to Closed

No answer for a long time, closing the issue.

Actions

Also available in: Atom PDF