Project

General

Profile

Actions

Bug #33873

closed

l10n_parent wrong after moving translated CEs

Added by Georg Ringer almost 13 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Category:
Workspaces
Target version:
Start date:
2012-02-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Thanks to #33592 it is now possible (again?) to move content elements which got a translation. the tranlation is now moved and stays in the correct language but it seems there is another minor bug.
The moved translation (or better I guess its placeholder) doesn't have the correct l10n_parent as there is this button in page module "Copy default content elements [1]".

could be also possible that this is a problem of the page module but I doubt.


Files

ce-diff.png (16.2 KB) ce-diff.png Georg Ringer, 2012-02-17 09:27
Actions #1

Updated by Tolleiv Nietsch almost 13 years ago

  • Status changed from New to Accepted
  • Assignee set to Tolleiv Nietsch
Actions #2

Updated by Georg Ringer almost 13 years ago

just as a hint.

count comes from class.tx_cms_layout.php =>

function getNonTranslatedTTcontentUids($defLanguageCount, $id, $lP) {
        if ($lP && count($defLanguageCount)) {

            // Select all translations here:
            $queryParts = $this->makeQueryArray('tt_content', $id, 'AND sys_language_uid=' . intval($lP) . ' AND l18n_parent IN (' . implode(',', $defLanguageCount) . ')');
            $result = $GLOBALS['TYPO3_DB']->exec_SELECT_queryArray($queryParts);
...

funny is phpdoc:
Selects across columns, but within in the same PID. Columns are expect to be the same for translations and original but this may be a conceptual error (?)

a workspace overlay is missing IMO here?

Actions #3

Updated by Georg Ringer almost 13 years ago

are you sure the problem is not in tcemain/tx_version?

screenshot shows the 2 content elemnts + translation

Actions #4

Updated by Georg Ringer over 12 years ago

How to test: use a current master

  1. Create 2 pages, both with translations, both with one translated content element
  2. Switch to workspaces
  3. Cut 1 content element from one page and paste it into the 2nd page
  4. See that at the 2nd page that there are 4 content elements, 2 in default, 2 in translations and still the button "copy default content element"
  5. apply patch
  6. reload page module of page 2
  7. if works, review it
Actions #5

Updated by Gerrit Code Review over 12 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9451

Actions #6

Updated by Michael Stucki almost 11 years ago

  • Category changed from Bugs to Workspaces
Actions #7

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #8

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/9451

Actions #9

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/9451

Actions #10

Updated by Mathias Schreiber almost 10 years ago

  • Target version set to 7.5
Actions #11

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/9451

Actions #12

Updated by Mathias Schreiber over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF