Bug #33873
closed
l10n_parent wrong after moving translated CEs
Added by Georg Ringer over 12 years ago.
Updated almost 7 years ago.
Description
Thanks to #33592 it is now possible (again?) to move content elements which got a translation. the tranlation is now moved and stays in the correct language but it seems there is another minor bug.
The moved translation (or better I guess its placeholder) doesn't have the correct l10n_parent as there is this button in page module "Copy default content elements [1]".
could be also possible that this is a problem of the page module but I doubt.
Files
- Status changed from New to Accepted
- Assignee set to Tolleiv Nietsch
just as a hint.
count comes from class.tx_cms_layout.php
=>
function getNonTranslatedTTcontentUids($defLanguageCount, $id, $lP) {
if ($lP && count($defLanguageCount)) {
// Select all translations here:
$queryParts = $this->makeQueryArray('tt_content', $id, 'AND sys_language_uid=' . intval($lP) . ' AND l18n_parent IN (' . implode(',', $defLanguageCount) . ')');
$result = $GLOBALS['TYPO3_DB']->exec_SELECT_queryArray($queryParts);
...
funny is phpdoc:
Selects across columns, but within in the same PID. Columns are expect to be the same for translations and original but this may be a conceptual error (?)
a workspace overlay is missing IMO here?
are you sure the problem is not in tcemain/tx_version?
screenshot shows the 2 content elemnts + translation
How to test: use a current master
- Create 2 pages, both with translations, both with one translated content element
- Switch to workspaces
- Cut 1 content element from one page and paste it into the 2nd page
- See that at the 2nd page that there are 4 content elements, 2 in default, 2 in translations and still the button "copy default content element"
- apply patch
- reload page module of page 2
- if works, review it
- Status changed from Accepted to Under Review
- Category changed from Bugs to Workspaces
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/9451
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/9451
- Target version set to 7.5
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/9451
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF