Project

General

Profile

Actions

Feature #34624

open

Changing the type field of a new element should not result in saving

Added by Nico de Haen about 12 years ago. Updated about 4 years ago.

Status:
Accepted
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2012-03-07
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

This is really an old gremlin, but I couldn't find an issue related to that.
Changing the type field of a new element should not result in saving that element.

This is for 3 reasons:
1. There is no validation (possible) since the required fields of a certain type may be not visible in the other types configuration
2. If you click on "Cancel" instead of "Ok" you will have a mixed form: the type field selector shows the new type but the form is still displayed with the old types configuration
3. For usability reasons any dataset should only be saved when an editor clicks the save button

As you probably know this behaviour is almost as old as TYPO3, maybe we can get rid of it in 6.0? ;-)


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #89220: Revert value of input if confirmation modal is not acceptedClosed2019-09-21

Actions
Actions #1

Updated by Oliver Hader about 12 years ago

  • Tracker changed from Bug to Feature
Actions #2

Updated by Mathias Schreiber over 9 years ago

  • Target version set to 7.4 (Backend)
Actions #3

Updated by Susanne Moog almost 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #4

Updated by Benni Mack over 8 years ago

  • Target version changed from 7.5 to 8 LTS
Actions #5

Updated by Riccardo De Contardi about 7 years ago

  • Target version changed from 8 LTS to 9.0
Actions #6

Updated by Susanne Moog over 6 years ago

  • Target version deleted (9.0)
Actions #7

Updated by Riccardo De Contardi over 5 years ago

It still comes true for the latest master.

Quick way to test it:

1) create a content element, type: text - write "test" as headline
2) Save it
3) Change the CType into "table" (for example)

the modal shows the message:

This change will affect which fields are available in the form. Would you like to save now in order to refresh the display?

4) click on "Cancel" instead of ok

Results

- the CType field still shows "Table"
- but the remaining backend form is still the one for the "text" element

Actions #8

Updated by Riccardo De Contardi over 5 years ago

  • Status changed from New to Needs Feedback

About this issue, on a second thought I don't know if it can be considered valid anymore (maybe not):

In fact, since TYPO3 7.6 if you perform the points 1-4 of my previous comment:

1) create a content element, type: text - write "test" as headline
2) Save it
3) Change the CType into "table" (for example)
4) click on "Cancel" instead of "Ok"

You will end with a "mixed" form where the CType field still shows "Table" , and the remaining backend form is still the one for the "text" element; but the form is not saved
If you try to close it, another modal tells you that there are unsaved properties and asks you a confirm (save or discard)

Do you think that it is sufficient to consider this issue solved? Thank you!

Actions #9

Updated by Harald Atteneder over 4 years ago

  • Related to Task #89220: Revert value of input if confirmation modal is not accepted added
Actions #10

Updated by Susanne Moog about 4 years ago

  • Status changed from Needs Feedback to Accepted

@Riccardo: I don't think so, I think the problem is:

If you have a required field in a content element and you create a new element where that required field is displayed > change the type without filling the field -> click "save" in the modal for reloading -> you now have a saved element where you did not fill in the required field.

Actions

Also available in: Atom PDF