Feature #37595
closed
Allow ext_icon.png besides ext_icon.gif
Added by Felix Kopp over 12 years ago. Updated about 6 years ago.
100%
Description
Allow ext_icon.png as extension icon besides ext_icon.gif.
Must be added to extension manager and typo3-menu / module menu and several other places.
Files
| 37595.patch (5.58 KB) 37595.patch | Joh. Feustel, 2012-08-16 16:29 |
Updated by Jigal van Hemert over 12 years ago
- Tracker changed from Bug to Feature
- Status changed from New to Accepted
- Priority changed from Should have to Could have
Updated by Steffen Ritter over 12 years ago
a sprite icon name should be possible to
Updated by Thomas Deinhamer over 12 years ago
I'd like to have this also! Alpha transparency for the win!
Updated by Felix Kopp over 12 years ago
Should we move completely to PNG and drop GIF from the core?
That would make the listing easier, because file_exists calls need to be send.
Updated by Georg Ringer over 12 years ago
+1 for dropping with using call to deprecationlog
Updated by Felix Kopp over 12 years ago
Georg, you say drop .gif support completely for 6.2?
Updated by Georg Ringer over 12 years ago
yeah why not... everything which happens if there is an ext which got no icon is that no icon is display, which means a general fallback icon is shown
Updated by Joh. Feustel over 12 years ago
- File 37595.patch 37595.patch added
I already created a patch for support of gif,jpg and png, waht do you think?
Uses new mehtod to find the icon and stores it to $GLOBALS['TYPO3_LOADED_EXT'][$_EXTKEY]['ext_icon'];
This method could also be extended somehow to be able to store somewhere in Resources/Public later
Updated by Georg Ringer over 12 years ago
patch looks good, but I would remove jpg and call t3lib_div::deprecationLog() for gif
Updated by Ingo Renner over 12 years ago
Georg Ringer wrote:
patch looks good, but I would remove jpg and call t3lib_div::deprecationLog() for gif
I agree, no jpg for icons. I don't care too much about deprecating gif, it's just fine to have, I wouldn't object it either though.
Updated by Gerrit Code Review over 12 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13886
Updated by Gerrit Code Review over 12 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13888
Updated by Gerrit Code Review over 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13888
Updated by Joh. Feustel over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 3358716ad369d87144987a0f40026f1b25dcd281.
Updated by Ingo Renner over 12 years ago
- Status changed from Resolved to Accepted
- % Done changed from 100 to 90
some issues not fixed in review process...
Updated by Gerrit Code Review over 12 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13898
Updated by Ingo Renner over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 90 to 100
Applied in changeset a1d5aab11e3087181803777b8485dc2a67cd3b6f.
Updated by