Project

General

Profile

Actions

Bug #42775

closed

Saving one tab, deleted entries from other tabs

Added by Jan-Erik Revsbech about 12 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Extension Manager
Target version:
-
Start date:
2012-11-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When storing extension configuration in different tabs, saving one tab, will delete/reset all values in other tabs.

In order to provoke the error, just create an ext_conf_template with

  1. cat=Basic/; type=int+; label=Test key1
    key1 =
  1. cat=WebService/; type=string; label=Test key2
    key2 =

Then go to the extension manager, and setting value of key2, will reset the value of key1 and vice versa.

The error related to ConfigurationUtility::getCurrentConfiguration which looks for

$GLOBALS['TYPO3_LOADED_EXT'][$extensionKey]['key']
which is never set.

Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Task #44818: Restructure ConfigurationUtility and ConfigurationItemRepositoryClosed2013-01-25

Actions
Related to TYPO3 Core - Bug #44559: "Cat" parameter for values set via ext_conf_template.txt are NOT taken into accountClosedHelmut Hummel2013-01-16

Actions
Has duplicate TYPO3 Core - Bug #44700: EM fails reading current configurationClosedFrancois Suter2013-01-21

Actions
Has duplicate TYPO3 Core - Bug #44781: ConfigurationUtility->getCurrentConfiguration only delivers default configurationClosed2013-01-24

Actions
Actions #1

Updated by Jan-Erik Revsbech about 12 years ago

Debugging further, i see that the getCurrentConfiguration (which is only used by the extension manager backend) is calling $this->configurationItemRepository->createArrayFromConstants

which returns an array looking like this

array (
'key1' => array(
'cat' => ' Basic'
'subcat' => 'x/z',
...
'value' => ''
'default_value' => ''
)
)

Which makes a lot os sense. But it does not make sence to call array_merge_recursive_overrule with this array and the currenc extConf which will look simething like

array(
'key1' => 'value1'
)
Actions #2

Updated by Jan-Erik Revsbech about 12 years ago

Hmm, it gets even worse when having nested configuration with first.second = value

Actions #3

Updated by Jan-Erik Revsbech about 12 years ago

The error occurs when merging the ConfigurationUtility internal "valued" configuration with the serilized "nested" configuration, which doesnt make to much sense. I submitted a patch set which convertes to "valued" before merging default with existing. This seems to fix the problems.

Actions #4

Updated by Gerrit Code Review about 12 years ago

  • Status changed from New to Under Review

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16280

Actions #5

Updated by Gerrit Code Review almost 12 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17720

Actions #6

Updated by Christian Kuhn almost 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Oliver Hader over 11 years ago

  • Target version set to 2222
Actions #8

Updated by Oliver Hader over 11 years ago

  • Project changed from 2269 to TYPO3 Core
Actions #9

Updated by Oliver Hader over 11 years ago

  • Category set to Extension Manager
Actions #10

Updated by Oliver Hader over 11 years ago

  • Target version deleted (2222)
Actions #11

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF