Task #44818
closedRestructure ConfigurationUtility and ConfigurationItemRepository
100%
Description
Restructure ConfigurationUtility and ConfigurationItemRepository:
These classes have no good separation and have no good scope separation. This leads to code smell and hard understanding of what is going on. For example, ConfigurationUtility calls createArrayFromConstants() of ConfigurationItemRepository, and violates a clean access separation (the utility should not call some repository method). All in all, the code is wired and hard to understand.
Separation idea:- Utility should take care of getting current configuration of some extension and merging with default values
- Repository should create the object hierachy from given merged configuration
Maybe it is even more wise to merge both classes into one (only to the repo), but that would work only, if the configuration is only needed for those repository method, and not otherwise.
All in all, this code already lead to several issues and should be done in a more clean and understandable way.
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17731
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17731
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17759
Updated by Christian Kuhn over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Patches merged in 6.1 and 6.0
Updated by Oliver Hader over 11 years ago
- Project changed from 2269 to TYPO3 Core