Project

General

Profile

Actions

Task #49769

closed

Replace usage of deprecated BasicFileUtility

Added by Markus Klein almost 11 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2014-03-23
Due date:
% Done:

100%

Estimated time:
0.00 h
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Sprint Focus:

Subtasks 1 (0 open1 closed)

Task #57209: Remove deprecation of BasicFileUtility::init until core stops using itClosed2014-03-23

Actions
Actions #1

Updated by Ernesto Baschny over 10 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (6.2.0)

What do you mean with "FileUtility"? I cannot find this class in the Core.

Indeed BasicFileUtility is still being used by some classes, some of which lead to bugs in the backend. For example the ElementBrowser issue (#47648).

Actions #2

Updated by Markus Klein over 10 years ago

I guess this was a copy&paste error. Indeed, the class does not exist. Sorry for that.

Shall we generalize the ticket to refer to the usage of BasicFileUtility in general?

Actions #3

Updated by Alexander Opitz over 10 years ago

  • Tracker changed from Bug to Task
  • Subject changed from FileUtility still uses deprecated BasicFileUtility to Replace usage of deprecated BasicFileUtility
  • Status changed from Needs Feedback to New
Actions #4

Updated by Alexander Opitz over 10 years ago

I started to patch TYPO3\CMS\Core\DataHandling\DataHandler and stumpled across folowing problem.

The uploads/ folder, this folder isn't maintained default within a FAL storage.

So the question is, do we want to add "uploads/" as a default FAL storage?

I wouldn't be happy with that, as this will get editors to the point uploading images every time they are used.

Suggestions please. :)

Actions #5

Updated by Ernesto Baschny over 10 years ago

@Alexander, AFAIK the default storage with the id "0" exists and embraces the complete TYPO3_site, so if you want to refer to files in "uploads/" just use this storage.

@Markus, Having an issue for each class involved would help keeping track of the process. To me it seems to be:

  • DataHandler
  • backend / FileController
  • impext / ImportExport
  • ElementBrowser (#47648)
  • frontend / GifBuilder
  • lowlevel / DoubleFilesCommand (will probably have to be completely rewritten for FAL anyway - or is obsolete...)
  • lowlevel / RteImagesCommand
  • rtehtmlarea / BrowserLinks and SelectImage

Maybe more. Search for BasicFileUtility and ExtendedFileUtility (which extends the basic one...).

Actions #6

Updated by Ernesto Baschny over 10 years ago

  • Category set to File Abstraction Layer (FAL)
  • Status changed from New to Accepted
  • Target version set to 6.2.0
Actions #7

Updated by Marc Bastian Heinrichs about 10 years ago

If I got it right ExtendedFileUtility is not deprecated, but ExtendedFileUtility and BasicFileUtility are coupled. In most places ExtendedFileUtility is used, the deprecated init method of BasicFileUtility is called.
So ExtendedFileUtility needs also to be decoupled from BasicFileUtility.

Actions #8

Updated by Markus Klein about 10 years ago

Either we manage to remove all Core internal calls to BasicFileUtility, or we remove the deprecation log message.

Actions #9

Updated by Marc Bastian Heinrichs about 10 years ago

I think the best chance to improve the current behaviour is to remove the deprecation of the init method and to explicit deprecate the functions in BasicFileUtility, that should not be used from the outside anymore, check and change the internal calls to them.

Actions #10

Updated by Ernesto Baschny about 10 years ago

  • Estimated time set to 0.00 h

Cleaning up the mess can be tackled for 6.3 or later. For now (6.2) we should fix it like Ma-Ba suggests, see #57209.

Actions #11

Updated by Markus Klein almost 10 years ago

  • Target version changed from 6.2.0 to 7.0
  • Estimated time set to 0.00 h
Actions #12

Updated by Mathias Schreiber over 9 years ago

  • Target version changed from 7.0 to 7.1 (Cleanup)
Actions #13

Updated by Markus Klein about 9 years ago

  • Status changed from Accepted to Closed
  • Target version deleted (7.1 (Cleanup))
  • Translation missing: en.field_remaining_hours deleted (0.0)

Not worth keeping this ticket any longer. There will be a time finally to get rid of this.

Actions

Also available in: Atom PDF