Bug #50274

Problem with Form extension and standard search

Added by Thomas Etter over 6 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2013-07-22
Due date:
% Done:

100%

TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When form extension is loaded and a standard search form is placed on a page an error shows up when loading the page with the search plugin ("oops an error occured!").

screenshot.PNG View (3.44 KB) Thomas Etter, 2014-02-03 10:27

formController.patch View (1.44 KB) Oliver Hader, 2014-03-04 16:03


Related issues

Related to TYPO3 Core - Bug #31572: TypoScript FORM-Object produces Exception Closed 2011-11-04

Associated revisions

Revision 50a08fc8 (diff)
Added by Oliver Hader over 5 years ago

[BUGFIX] Make standard-search working with EXT:form installed

The standard-search relies on basic form-functionality.
But if EXT:form is installed, that functionality is overlaid
and the result is wrong.

Provide a flag so that standard-search can request to use
the "basic" form-functionality, preventing EXT:form from
dealing with it.

Change-Id: I52cbd6cecc7222217ff766393dd37ad9d1a9aa30
Resolves: #50274
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/28042
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

History

#1 Updated by Philipp Gampe over 6 years ago

  • Status changed from New to Needs Feedback
  • Priority changed from Must have to Should have

Please turn on debugging by setting your IP to the devIpMask setting (Install Tool) and show us the real error message.

#2 Updated by Koen Van Nuffelen over 6 years ago

http://wiki.typo3.org/Exception/CMS/1 says:

typo3 6.1.0
indexed search

I get this error after installing indexed search.

Oops, an error occurred!

PHP Catchable Fatal Error: Argument 2 passed to TYPO3\CMS\Form\Controller\FormController::cObjGetSingleExt()
must be an array, null given, called in
/var/www/vhosts/typo3_cores/typo3_src-6.1.0alpha1/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
on line 730 and defined in
/var/www/vhosts/typo3_cores/typo3_src-6.1.0alpha1/typo3/sysext/form/Classes/Controller/FormController.php line 93

Solution

After uninstalling extension system extension form it works

=> This solutions works, but not really a solution if you want to use the form system extension.

#3 Updated by Christian Bernet over 6 years ago

sorry for the bad error message from thomas.

thanks to koen van nuffelen, but * we need the form extension installed.*

the error message is:

PHP Catchable Fatal Error: Argument 2 passed to TYPO3\CMS\Form\Controller\FormController::cObjGetSingleExt() must be an array, null given, called in D:\wamp\www\psroggwil\typo3\sysext\frontend\Classes\ContentObject\ContentObjectRenderer.php on line 732 and defined in D:\wamp\www\psroggwil\typo3\sysext\form\Classes\Controller\FormController.php line 93

#4 Updated by Alexander Opitz over 6 years ago

  • Category set to Indexed Search
  • Status changed from Needs Feedback to New

#5 Updated by Christian Bernet over 6 years ago

we have the problem without the indexed search extension installed (only with the placed search content element)!
so i think the category indexed search is wrong. I think it shoud be Form wizzard.

#6 Updated by Joris Willems about 6 years ago

Indeed. Uninstalling the Form sysext "fixes" the issue.
You can also apply the changes proposed in this patch:
https://review.typo3.org/#/c/6537/

#7 Updated by Ernesto Baschny about 6 years ago

  • Category changed from Indexed Search to Form Framework
  • Status changed from New to Needs Feedback
  • Is Regression set to No

This is most probably the same as issue #31572. Check out the patch that is pending in the review queue there if that solves this problem. If it's the same issue, we can also close this one and continue only on #31572.

#8 Updated by Thomas Etter about 6 years ago

The changes in https://review.typo3.org/#/c/6537/ solve the crash issue but standard search not working properly, the form is not displayed correctly. I get
###LABEL### ###FIELD### as output for the search field.

#9 Updated by Alexander Opitz almost 6 years ago

As #31572 was merged, does this issue is resolved in latest TYPO3?

Das the issue with "###LABEL### ###FIELD###" still exist?

#10 Updated by Thomas Etter almost 6 years ago

Alexander Opitz wrote:

As #31572 was merged, does this issue is resolved in latest TYPO3?

Das the issue with "###LABEL### ###FIELD###" still exist?

Yes, it still exists. The following line solves the problem:

in /typo3/sysext/form/Classes/Controller/FormController.php
line 107
'10.' => is_array($mergedTypoScript) ? $mergedTypoScript : array(),

#11 Updated by Alexander Opitz almost 6 years ago

  • Status changed from Needs Feedback to New

Ok, would you like to provide a patch against master by using Gerrit? http://wiki.typo3.org/CWT

#12 Updated by Thomas Etter almost 6 years ago

Alexander Opitz wrote:

Ok, would you like to provide a patch against master by using Gerrit? http://wiki.typo3.org/CWT

Sorry, I have to correct myself: The standard search form still isn't displayed, the only difference between the two patches is that with our patch, no form is displayed at all (no labels either). I had to add the form manually via html, the standard search is still working though.

#13 Updated by Alexander Opitz almost 6 years ago

So which TYPO3 are you running now?
And which issue is left (without using a patch)?

#14 Updated by Alexander Opitz almost 6 years ago

  • Status changed from New to Needs Feedback

#15 Updated by Thomas Etter almost 6 years ago

Alexander Opitz wrote:

So which TYPO3 are you running now?
And which issue is left (without using a patch)?

TYPO3 version is 6.1.7
Without using a patch i get Label code displayed but no search form. The search itself is working.

#16 Updated by Alexander Opitz almost 6 years ago

Ok, can you please add an illustrative screenshot?

#17 Updated by Thomas Etter almost 6 years ago

Alexander Opitz wrote:

Ok, can you please add an illustrative screenshot?

#18 Updated by Alexander Opitz almost 6 years ago

  • Status changed from Needs Feedback to New

#19 Updated by Stefan Neufeind over 5 years ago

I can confirm the non-replaced labels with current 6.2-master and the default search-form.

#20 Updated by Stefan Neufeind over 5 years ago

Problem appears if EXT:form is installed, no matter if its static template is loaded or not. Thanks to Olly for the clarification. If you can, deactivate EXT:form for the moment.
EXT:form "overlays" the form-functionality and produces the undesired output.

#22 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28042

#23 Updated by Oliver Hader over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#24 Updated by Bjoern Jacob over 4 years ago

  • Category changed from Form Framework to 1602

#25 Updated by Bjoern Jacob over 3 years ago

  • Category changed from 1602 to Form Framework

#26 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF