Task #50349

Reduce SQL queries of page tree in workspaces

Added by Oliver Hader almost 8 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
Start date:
2013-07-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

Nodes of the page tree are highlighted, if that particular node has versioned elements in the current workspace. However, this is determined by iterating over all tables and all records for each page. If having installed many extensions with many tables any many records, this will produce a lot of SQL queries.

The process of "does have versions" can be stopped once the first version for a page/node has been found.


Related issues

Related to TYPO3 Core - Bug #61184: Backend - Page Tree in Workspace & Publish content - Performance Issue - BackendUtility::countVersionsOfRecordsOnPageClosed2014-08-26

Actions
Related to TYPO3 Core - Bug #66231: Workspace very slow loading page treeClosed2015-04-02

Actions
Related to TYPO3 Core - Task #69439: Enhance SQL query reduction in page tree in workspacesClosedOliver Hader2015-08-31

Actions
#1

Updated by Oliver Hader almost 8 years ago

  • Tracker changed from Bug to Task
#2

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22528

#3

Updated by Mathias Schreiber over 6 years ago

  • Target version set to 7.4 (Backend)

Hey Olly, wanna meet up to dig into ths one?
The idea itself is the right way.

#4

Updated by Alexander Opitz about 6 years ago

In #66231 this patch seams to be used in a 1:1 manner which was tested in #61184 and reported as fine.
So we should go forward with this for TYPO3 CMS 7 LTS.

#5

Updated by Grigori Prokhorov about 6 years ago

Hi Alexander,

what speaks against including just https://review.typo3.org/#/c/38700/ in the next 6.2.x?

I'm asking since IF the situation occurs which this patch resolves, it actually makes the usage of the workspaces completely impossible.
The patch from #66231 as a "stand-alone" solution (as compared to https://review.typo3.org/#/c/22528/) only affects a very specific part of the core since the affected method is used in exactly those two classes which are included.

Best,
Grigori

#6

Updated by Christian Opitz almost 6 years ago

This issue makes the workspace feature nearly unusable. +1 for getting this into 6.2

#7

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22528

#8

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22528

#9

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22528

#10

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22528

#11

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22528

#12

Updated by Nicole Cordes almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#13

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41425

#14

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41425

#15

Updated by Nicole Cordes almost 6 years ago

  • Status changed from Under Review to Resolved
#16

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41553

#17

Updated by Nicole Cordes almost 6 years ago

  • Status changed from Under Review to Resolved
#18

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42541

#19

Updated by Oliver Hader almost 6 years ago

  • Status changed from Under Review to Closed

Follow-up #69439

#20

Updated by Oliver Hader almost 6 years ago

  • Status changed from Closed to Resolved
#21

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF