Bug #66231
closed
Workspace very slow loading page tree
100%
Description
Hello everybody,
I wish that i'm posting in the right place for this issue that i have, with my team we have just upgraded from 4.6 to 6.2 Since then editors have major performance issues in the typo3 backend.
They get a lot of timeouts when trying to open pages in the backend ("Connection Problem Sorry, but an error occurred while connecting to the server. Please check your network connection.")
It takes sometimes up to 5 minutes until the page tree is opened.
We saw the the request to typo3/ajax.php?ajaxID=ExtDirect::route&namespace=TYPO3.Components.
PageTree really takes a long long time, get´s timeouts or even responds with 500.
Basically the backend becomes impossible to work in.
i think the problem is realated to the TYPO3\CMS\Workspaces\ExtDirect\AbstractHandler.
File : AbstractHandler.php
92 : $versions = $this->getWorkspaceService()->selectVersionsInWorkspace($this->getCurrentWorkspace(), 0,
99, -1, 0, 'tables_select', $this>validateLanguageParameter($parameters));
Any body can help me on this ?
Thanks in advance.
Updated by Mohamed Masmoudi over 9 years ago
Here the message from firebug console :
POST http://mydomain/directory/typo3/ajax...axID=ExtDirect::route&namespace=TYPO3.Workspaces Aborted 29,94s
Referer http://mydomain/directory/typo3/mod.php?M=web_WorkspacesWorkspaces&moduleToken=2b08a7ba
Updated by Martin Tepper over 9 years ago
Maybe this fix will solve it.
https://github.com/ohader/TYPO3.CMS-Workspaces/commit/e4fe2cba200ad18b1d3ba98fc700196fc10c0556
Could you check it please?
Related to https://forge.typo3.org/issues/61184
Updated by Martin Tepper over 9 years ago
We checked the commit from Oliver and got a better performance. The difference is around 5 seconds!
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38700
Updated by Grigori Prokhorov over 9 years ago
Hi all,
Martin Trepper's patch from comment #66231-2 does in fact resolve the issue.
The original code is apparently yet unchanged in any TYPO3 CMS 6 version up1 to2 6.2.12, so that I don't quite see how this could solve this issue aside from being a temporary fix.
The only issue I have with the patch is that it drops the second part of the workspace record check, i.e. the WHERE-clause includes
'A.pid=-1' . ' AND A.t3ver_wsid=' . $workspaceId . ' AND A.t3ver_oid=B.uid' . BackendUtility::deleteClause($tableName, 'A') . BackendUtility::deleteClause($tableName, 'B')
what for tt_content translates to
SELECT
B.uid as live_uid,
B.pid as live_pid,
A.uid as offline_uid
FROM
tt_content as A,
tt_content as B
WHERE
A.pid = -1
AND A.t3ver_wsid = ###WORKSPACE_ID###
AND A.t3ver_oid = B.uid
AND A.deleted = 0
AND B.deleted = 0
but drops the part
A.t3ver_oid = B.uid
AND A.t3ver_state<>4
OR A.t3ver_oid=B.t3ver_move_id
AND A.t3ver_state=4
This means that the versioning state is not regarded at all, although it's not quite clear to me why it should have been regarded in the first place since an editor can not select the versioning state when looking at the page tree anyway.
I am therefore "+1"-ing the solution proposed in #66231 to be included into the core as a proper fix for this issue.
Best,
Grigori
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22528
Updated by Gerrit Code Review over 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22528
Updated by Nicole Cordes over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 37cd2d5084d48e77e17e8fb14ecbb5e55c7946c7.
Updated by Gerrit Code Review over 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41425
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41425
Updated by Nicole Cordes over 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset d2c4bbbb34ffe31ad2007573158819b3ce4aee65.
Updated by Gerrit Code Review over 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41553
Updated by Nicole Cordes over 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset c45de676a41672f4780875e05fd389cbb66a8a96.
Updated by Sara no-lastname-given over 9 years ago
We've tried this fix but it just breaks the website.
Need to go live at the end of this week so if anyone has any ideas on fixing this problem I'd be very grateful!
A new ticket has been opened detailing the problems we're having https://forge.typo3.org/issues/69068
Updated by