Project

General

Profile

Actions

Task #69439

closed

Enhance SQL query reduction in page tree in workspaces

Added by Oliver Hader almost 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
-
Start date:
2015-08-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
Sprint Focus:

Description

This changeset is a follow-up to the changes for issue #50349 and
it partly reverts the changes that have been introduced back then.

The most important changes are:
  • Allow early return on first found record in hasPageVersions.
    The previous implementation performed SQL queries on all tables
    that are defined in the global TCA array. Now the first version
    occurrence is enought to infer that a page has versions.
  • Integrate hooks to modify the determined results. This way, the
    meaning of having versions can be modified by hooks further.
    For instance the default behavior of the TYPO3 core is to create
    a workspace version record on persisting the same record in the
    backend - without any actual changes to the data model.

Related issues 5 (0 open5 closed)

Related to TYPO3 Core - Task #50349: Reduce SQL queries of page tree in workspacesClosed2013-07-24

Actions
Related to TYPO3 Core - Bug #66231: Workspace very slow loading page treeClosed2015-04-02

Actions
Related to TYPO3 Core - Bug #61184: Backend - Page Tree in Workspace & Publish content - Performance Issue - BackendUtility::countVersionsOfRecordsOnPageClosed2014-08-26

Actions
Related to TYPO3 Core - Bug #69068: Workspace not opening page treeClosed2015-08-14

Actions
Related to TYPO3 Core - Bug #77618: Workspace PageTree can become super-slowClosed2016-08-24

Actions
Actions #1

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42944

Actions #2

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42541

Actions #3

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42944

Actions #4

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42541

Actions #5

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42944

Actions #6

Updated by Tobias Schaefer over 8 years ago

After updating from 6.2.14 to 6.2.15 rendering of the page tree in a workspace takes now 28sec. With 6.2.14 it takes 5 sec. I then used the patch set 3 with 6.2.15 but it still takes 28 sec.

Actions #7

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42944

Actions #8

Updated by Markus Sommer over 8 years ago

  • Assignee set to Oliver Hader
Actions #9

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42944

Actions #10

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42944

Actions #11

Updated by Oliver Hader about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Herbert Sojnik over 7 years ago

Sorry for asking, but maybe I'm blind:
In which TYPO3 version this patch is integrated?

Best regards,
Herbert

Actions #14

Updated by Herbert Sojnik over 7 years ago

@ Viktor Livakivskyi:
Thanks!

Actions #15

Updated by Anonymous almost 6 years ago

Can anybody say in which versions of TYPO3 this is fixed? Have the problem still in 7.6.29. If it was just fixed in 8.1 - why not backported to 7.6, cause it breaks large websites with workspaces...Cheers!

Actions #16

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF