Task #69439

Enhance SQL query reduction in page tree in workspaces

Added by Oliver Hader about 4 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
-
Start date:
2015-08-31
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
Sprint Focus:

Description

This changeset is a follow-up to the changes for issue #50349 and
it partly reverts the changes that have been introduced back then.

The most important changes are:
  • Allow early return on first found record in hasPageVersions.
    The previous implementation performed SQL queries on all tables
    that are defined in the global TCA array. Now the first version
    occurrence is enought to infer that a page has versions.
  • Integrate hooks to modify the determined results. This way, the
    meaning of having versions can be modified by hooks further.
    For instance the default behavior of the TYPO3 core is to create
    a workspace version record on persisting the same record in the
    backend - without any actual changes to the data model.

Related issues

Related to TYPO3 Core - Task #50349: Reduce SQL queries of page tree in workspaces Closed 2013-07-24
Related to TYPO3 Core - Bug #66231: Workspace very slow loading page tree Closed 2015-04-02
Related to TYPO3 Core - Bug #61184: Backend - Page Tree in Workspace & Publish content - Performance Issue - BackendUtility::countVersionsOfRecordsOnPage Closed 2014-08-26
Related to TYPO3 Core - Bug #69068: Workspace not opening page tree Closed 2015-08-14
Related to TYPO3 Core - Bug #77618: Workspace PageTree can become super-slow Closed 2016-08-24

Associated revisions

Revision 319b0aa3 (diff)
Added by Oliver Hader over 3 years ago

[TASK] Enhance SQL query reduction in page tree in workspaces

This changeset is a follow-up to the changes for issue #50349 and
it partly reverts the changes that have been introduced back then.

The most important changes are:

  • Allow early return on first found record in hasPageVersions.
    The previous implementation performed SQL queries on all tables
    that are defined in the global TCA array. Now the first version
    occurrence is enough to infer that a page has any versions.
  • Integrate hooks to modify the determined results. This way, the
    meaning of having versions can be further modified by hooks.
    For instance, the default behavior of the TYPO3 core is to create
    a workspace version record on persisting the same record in the
    backend - without any actual changes to the data model.

Resolves: #69439
Releases: master
Change-Id: I119a79d8fad82b0dc5891861af45ecfdbc681820
Reviewed-on: https://review.typo3.org/42944
Reviewed-by: Andreas Wolf <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42944

#2 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42541

#3 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42944

#4 Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42541

#5 Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42944

#6 Updated by Tobias Schaefer almost 4 years ago

After updating from 6.2.14 to 6.2.15 rendering of the page tree in a workspace takes now 28sec. With 6.2.14 it takes 5 sec. I then used the patch set 3 with 6.2.15 but it still takes 28 sec.

#7 Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42944

#8 Updated by Markus Sommer almost 4 years ago

  • Assignee set to Oliver Hader

#9 Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42944

#10 Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42944

#11 Updated by Oliver Hader over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Herbert Sojnik over 2 years ago

Sorry for asking, but maybe I'm blind:
In which TYPO3 version this patch is integrated?

Best regards,
Herbert

#14 Updated by Herbert Sojnik over 2 years ago

@ Viktor Livakivskyi:
Thanks!

#15 Updated by Tobias Gaertner about 1 year ago

Can anybody say in which versions of TYPO3 this is fixed? Have the problem still in 7.6.29. If it was just fixed in 8.1 - why not backported to 7.6, cause it breaks large websites with workspaces...Cheers!

#16 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF