Project

General

Profile

Actions

Bug #50437

closed

Filebrowser popup window has javascript error and stops working

Added by Claus Harup almost 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2013-07-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When trying to add an image to textpic I do the following:

Navigate to the desired folder holding my images.
The list of images is generated.
Clicking "Show thumbnails".
Realizing I am in the wrong folder -> trying to click on another folder.....

Filebrowser popup window has javascript error and stops working.....

Firebug gives me: "ReferenceError: jumpToUrl is not defined":


Files

screen.gif (34.6 KB) screen.gif Claus Harup, 2013-07-25 17:49
workaround_50437.patch (1002 Bytes) workaround_50437.patch Benjamin Pick, 2013-09-18 16:38

Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Bug #45859: Element Browser stops workingClosedBenni Mack2013-02-26

Actions
Related to TYPO3 Core - Bug #53826: JavaScript error when using foldertree (for files) selector popup in RTE, and icons not showingClosedJan-Erik Revsbech2013-11-21

Actions
Has duplicate TYPO3 Core - Bug #48249: File selection popup / JS errorClosed2013-05-16

Actions
Has duplicate TYPO3 Core - Bug #49825: FAL and ObjectBrowser looses Focus.Closed2013-07-09

Actions
Actions #1

Updated by Philipp Gampe almost 11 years ago

  • Status changed from New to Accepted
Actions #2

Updated by Eric Chavaillaz almost 11 years ago

I confirm this bug. And it's the same with file etc.

Actions #3

Updated by Ernesto Baschny almost 11 years ago

I can confirm that. The error that leads to that comes before and is:

Uncaught SyntaxError: Unexpected identifier browse_links.php?&id=&act=page&mode=file&expandFolder=1%3A%2FImages%2FAdmin…heckUniqueElement%7C%7Cinline.importElement[object%20HTMLInputElement]:277

On that line (277) we have:

parent.window.opener.inline.importElement("data-57-tt_content-259-image-sys_file_reference",table,uid,type);
Actions #4

Updated by Eric Chavaillaz almost 11 years ago

OK and how to fix that bug? Have you any idea?

Thanks

Actions #5

Updated by Benjamin Pick almost 11 years ago

The exact url is:

/typo3/browse_links.php?&id=&act=page&mode=file&expandFolder=1%3A%2Fuser_upload%2Fmarken%2Fm%2F&bparams=%7C%7C%7Cgif%2Cjpg%2Cjpeg%2Ctif%2Ctiff%2Cbmp%2Cpcx%2Ctga%2Cpng%2Cpdf%2Cai%7Cdata-90-tt_content-1130-image-sys_file_reference%7Cinline.checkUniqueElement%7C%7Cinline.importElement&SET[displayThumbs]=0&bparams=%7C%7C%7Cgif%2Cjpg%2Cjpeg%2Ctif%2Ctiff%2Cbmp%2Cpcx%2Ctga%2Cpng%2Cpdf%2Cai%7Cdata-90-tt_content-1130-image-sys_file_reference%7Cinline.checkUniqueElement%7C%7Cinline.importElement[object%20HTMLInputElement]

which parses into:

SET[displayThumbs]    0
act            page
bparams            |||gif,jpg,jpeg,tif,tiff,bmp,pcx,tga,png,pdf,ai|data-90-tt_content-1130-image-sys_file_reference|inline.checkUniqueElement||inline.importElement
bparams            |||gif,jpg,jpeg,tif,tiff,bmp,pcx,tga,png,pdf,ai|data-90-tt_content-1130-image-sys_file_reference|inline.checkUniqueElement||inline.importElement[object HTMLInputElement]
expandFolder        1:/user_upload/marken/m/
id    
mode            file

which is rather weird for 2 reasons: 1) normally the bparams GET parameter should only be used once, and 2) importElement is a function, not an object, so [object HTMLInputElement] doesn't make sense.

Actions #6

Updated by Benjamin Pick almost 11 years ago

Workaround: In typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php:507, add a type check:

                var theLocation = URL + add_act + add_mode + add_href + add_target + add_class + add_title + add_params' . ($addPassOnParams ? '+"' . $addPassOnParams . '"' : '') . '+(typeof(anchor)=="string"?anchor:"");

The underlying issue is that throughout the Typo3 framework, different variations of jumpToUrl are used: jumpToUrl(URL), jumpToUrl(URL,formEl) as well as jumpToUrl(URL,anchor).

Actions #7

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23889

Actions #8

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23889

Actions #9

Updated by Xavier Perseguers over 10 years ago

  • Is Regression set to No
Actions #10

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/24093

Actions #11

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/24094

Actions #12

Updated by Benjamin Pick over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF