Actions
Bug #52912
closedLink validator does not check links in input fields
Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2013-10-17
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Description
Linkvalidator ignores external links in input fields. One example is "External url" page type and its "url" field: it is ignored during the check.
This is reproducible with any field that is filled by the TYPO3 link wizard and has prety standard configuration:
'path' => array( 'exclude' => 1, 'label' => 'LLL:EXT:....', 'config' => array( 'type' => 'input', 'size' => '48', 'max' => '255', 'eval' => 'required,trim', 'wizards' => array( '_PADDING' => 2, 'link' => array( 'type' => 'popup', 'title' => 'Link', 'icon' => 'link_popup.gif', 'script' => 'browse_links.php?mode=wizard', 'JSopenParams' => 'height=300,width=500,status=0,menubar=0,scrollbars=1' ) ), 'softref' => 'typolink,typolink_tag,images,email[subst],url' ) ),There are two problems that cause the issue:
- TYPO3 link wizard creates external links without scheme portion. TYPO3 softref parse makes such links of type "string", which linkvalidator does not recognize. To detect the type proper;y as "external", linkvalidator should preprocess 'url' softrefs and prepend the scheme.
- Linkvalidator processes URLs only if there is a 'subst' entry in the result of the softparser. This will be true for some typolinks and for 'email[subst]' but not for 'url' declaration. Thus any external URL is ignored.
The problem is reproducible with linkvalidator in TYPO3 4.7 and TYPO3 6.2 beta 1.
Files
Actions