Project

General

Profile

Actions

Bug #52912

closed

Link validator does not check links in input fields

Added by Dmitry Dulepov about 11 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2013-10-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Linkvalidator ignores external links in input fields. One example is "External url" page type and its "url" field: it is ignored during the check.

This is reproducible with any field that is filled by the TYPO3 link wizard and has prety standard configuration:

        'path' => array(
            'exclude' => 1,
            'label' => 'LLL:EXT:....',
            'config' => array(
                'type'     => 'input',
                'size'     => '48',
                'max'      => '255',
                'eval'     => 'required,trim',
                'wizards'  => array(
                    '_PADDING' => 2,
                    'link'     => array(
                        'type'         => 'popup',
                        'title'        => 'Link',
                        'icon'         => 'link_popup.gif',
                        'script'       => 'browse_links.php?mode=wizard',
                        'JSopenParams' => 'height=300,width=500,status=0,menubar=0,scrollbars=1'
                    )
                ),
                'softref'  => 'typolink,typolink_tag,images,email[subst],url'
            )
        ),
There are two problems that cause the issue:
  1. TYPO3 link wizard creates external links without scheme portion. TYPO3 softref parse makes such links of type "string", which linkvalidator does not recognize. To detect the type proper;y as "external", linkvalidator should preprocess 'url' softrefs and prepend the scheme.
  2. Linkvalidator processes URLs only if there is a 'subst' entry in the result of the softparser. This will be true for some typolinks and for 'email[subst]' but not for 'url' declaration. Thus any external URL is ignored.

The problem is reproducible with linkvalidator in TYPO3 4.7 and TYPO3 6.2 beta 1.


Files

52912.diff (998 Bytes) 52912.diff Dmitry Dulepov, 2013-10-17 12:59

Related issues 2 (1 open1 closed)

Related to TYPO3 Core - Feature #89177: Change TsConfig Defaults of Linkvalidator and Enable all core fields containing linksNew2019-09-15

Actions
Related to TYPO3 Core - Bug #89265: Linkvalidator: URLs in RTE fields are not checkedClosed2019-09-25

Actions
Actions

Also available in: Atom PDF