Using Apache mod_rewrite in certain setups makes environment variables from original requests available in the target request as
REDIRECT_<envvar>, thus setting
The latter is currently not considered by TYPO3, thus the core updater cannot be disabled via the environment variable and the mentioned setup.
[BUGFIX] Use REDIRECT_ prefix as fallback for environment variables
The core uses values of environment variables for
disabling the core updater and to determine the
When setting the variable with mod_rewrite, certain server environments
prefix the variable name with REDIRECT_.
To ensure compatibility for this case, REDIRECT_
prefix is prepended as a fallback if the regular
variable is not set.
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
#5 Updated by Mathias Brodala over 5 years ago
Philipp Gampe wrote:
Can you create a patch for this? http://wiki.typo3.org/CWT
I now did this by modifying the existing change as written in the CWT, not sure if it ends up on the review server. Attached is the same change as patch in case it doesn't.
This patch enables retrieving
GeneralUtility::getIndpEnv() and adds
GeneralUtility::getRedirectEnvironmentVariable() for reading an environment variable possibly prefixed by
REDIRECT_ (up to 5 times).
#7 Updated by Mathias Brodala over 5 years ago
Gerrit Code Review wrote:
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123
Now it worked and was my fault: I did clone my local TYPO3.CMS repository to avoid downloading it all again. So obviously the remote URL was not git.typo3.org and thus everything failed.
#11 Updated by Mathias Brodala over 5 years ago
Helmut Hummel wrote:
Before moving further: What is on exact use case/ configuration where we will be affected by this?
Using Apache mod_rewrite in certain setups
What are these certain setups?
See the docblock for the new
Returns an environment variable taking possible "REDIRECT_"
prefixes into account (e.g. due to PHP running in CGI mode)
Thus the following combination is affected: Apache + mod_rewrite + PHP (CGI)
I admit that the mod_rewrite part is not mentioned in the docblock. Should it be added?