Project

General

Profile

Actions

Bug #53188

closed

REDIRECT_TYPO3_DISABLE_CORE_UPDATER ignored

Added by Mathias Brodala over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
Start date:
2013-11-27
Due date:
2013-11-27
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Using Apache mod_rewrite in certain setups makes environment variables from original requests available in the target request as REDIRECT_<envvar>, thus setting TYPO3_DISABLE_CORE_UPDATER becomes REDIRECT_TYPO3_DISABLE_CORE_UPDATER.

The latter is currently not considered by TYPO3, thus the core updater cannot be disabled via the environment variable and the mentioned setup.

See this Stackoverflow post for an explanation and link to the Apache source code.


Files

53188.patch (591 Bytes) 53188.patch Respect REDIRECT_TYPO3_DISABLE_CORE_UPDATER environment variable Mathias Brodala, 2013-10-29 14:51
53188-getindpenv.patch (3.38 KB) 53188-getindpenv.patch Implementation via GeneralUtility::getIndpEnv Mathias Brodala, 2014-03-05 14:33

Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #58358: Use REDIRECT_TYPO3_CONTEXT as fallback for TYPO3_CONTEXT environment variable Closed2014-04-30

Actions
Follows TYPO3 Core - Feature #52639: ext:install Environment variable to deactivate core updateClosedErnesto Baschny2013-10-09

Actions
Follows TYPO3 Core - Bug #53974: Environment variables prefixed with REDIRECT_ ignoredClosed2013-11-26

Actions
Actions #1

Updated by Philipp Gampe over 10 years ago

  • Status changed from New to Accepted

Can you create a patch for this? http://wiki.typo3.org/CWT

Actions #2

Updated by Mathias Brodala over 10 years ago

Here's the patch, as the way written in the CWT is far from trivial but the actual fix is.

Actions #3

Updated by Alexander Stehlik over 10 years ago

Should this be moved to GeneralUtility::getIndpEnv()?

Actions #4

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/25123

Actions #5

Updated by Mathias Brodala about 10 years ago

Philipp Gampe wrote:

Can you create a patch for this? http://wiki.typo3.org/CWT

I now did this by modifying the existing change as written in the CWT, not sure if it ends up on the review server. Attached is the same change as patch in case it doesn't.

This patch enables retrieving REDIRECT_TYPO3_DISABLE_CORE_UPDATER via GeneralUtility::getIndpEnv() and adds GeneralUtility::getRedirectEnvironmentVariable() for reading an environment variable possibly prefixed by REDIRECT_ (up to 5 times).

Actions #6

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123

Actions #7

Updated by Mathias Brodala about 10 years ago

Gerrit Code Review wrote:

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123

Now it worked and was my fault: I did clone my local TYPO3.CMS repository to avoid downloading it all again. So obviously the remote URL was not git.typo3.org and thus everything failed.

Actions #8

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123

Actions #9

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123

Actions #10

Updated by Helmut Hummel almost 10 years ago

Before moving further: What is on exact use case/ configuration where we will be affected by this?

In particular:

Using Apache mod_rewrite in certain setups

What are these certain setups?

Actions #11

Updated by Mathias Brodala almost 10 years ago

Helmut Hummel wrote:

Before moving further: What is on exact use case/ configuration where we will be affected by this?

In particular:

Using Apache mod_rewrite in certain setups

What are these certain setups?

See the docblock for the new GeneralUtility::getEnvironmentVariableWithRedirectPrefix() method:

Returns an environment variable taking possible "REDIRECT_"
prefixes into account (e.g. due to PHP running in CGI mode)

Thus the following combination is affected: Apache + mod_rewrite + PHP (CGI)

I admit that the mod_rewrite part is not mentioned in the docblock. Should it be added?

Actions #12

Updated by Chris topher almost 10 years ago

  • Subject changed from REDIRECT_TYPO3_DISABLED_CORE_UPDATER ignored to REDIRECT_TYPO3_DISABLE_CORE_UPDATER ignored
Actions #13

Updated by Mathias Brodala almost 10 years ago

Apparently the same issue also appears with PHP in FastCGI.

Actions #14

Updated by Gerrit Code Review almost 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123

Actions #15

Updated by Gerrit Code Review almost 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123

Actions #16

Updated by Gerrit Code Review almost 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123

Actions #17

Updated by Gerrit Code Review almost 10 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123

Actions #18

Updated by Gerrit Code Review almost 10 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25123

Actions #19

Updated by Steffen Müller almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #20

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF