TYPO3 Core

I stepped backwards and it seems to break when going from .30 to .31, with 4.5.30 the dam image versioning works.
The main dam extension is version 1.3.1

We have the same problem in one of our projects. Image in Workspace preview ( normal view and frame view with slider ) does not work with 4.5.31 and 4.5.32. The installed DAM version is 1.3.2.

After investigating this, i managed to find the cause of this issue. Between 4.5.30 and 4.5.31 there was a change in the enabledField() function ( /t3lib/class.t3lib_page.php ). There was a check for the parameter $noVersionPreview added, which is by default set to false. But the check for this parameter is wrong:

// Filter out versioned records
if (!$noVersionPreview) {
    $query .= ' AND ' . $table . '.pid<>-1';
}

This should be changed to:

// Filter out versioned records
if ((bool)$noVersionPreview) {
     $query .= ' AND ' . $table . '.pid<>-1';
}

Now the check means, if there is no version preview wanted, select only records with a pid <> -1 ( which are records created in a workspace environment ).

After manually fixing this in our installation, everything works again as expected.

Unfortunately, the suggested fix yesterday breaks the display of normal content ( tt_content ) in workspace preview. So dont use it. A working fix for the posted problem is still open.

I think that this should be marked as related or even a duplicate of #54948 and/or as related to #37065.

To anyone in need of a temporary solution, I would recommend reverting the appropriate changeset from #37065 (i.e. d114ddb3 for 4.5, f561b99 for 6.0, 3ac3429 for 6.1, and a81a581 for 6.2).

Is that still an issue in current 6.2 and 7.6 versions?