Bug #55835: Suggest wizard does not work correctly in flexforms - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (3)

GAYA La Nouvelle Agence
Markus Klein
Rémy DANIEL

Actions

Copy link

Bug #55835

closed

Suggest wizard does not work correctly in flexforms

Added by Philipp Wrann over 10 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Backend User Interface

Target version:

Start date:

2014-02-10

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

5.3

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

for my plugin i use multiple suggest wizards in the flexform.
The behaviour is really weird, once i select something in wizard a everything works, when selecting something in wizard b the option i chose in wizard a is taken instead. When i add a few elements via the browser to select c and i delete one of them all will vanish...

The shown options are correct but the wrong ones are insterted plus the weird problem with the removing of records....

could be regression
48474
47413

Files

Download all files

screen.jpg (65 KB) screen.jpg		Philipp Wrann, 2014-02-10 13:21
jsfunc.tceforms_suggest.js.patch (899 Bytes) jsfunc.tceforms_suggest.js.patch		GAYA La Nouvelle Agence, 2014-06-02 12:56

Related issues 6 (0 open — 6 closed)

Related to TYPO3 Core - Bug #52919: suggest wizard doesnt respect "uniqueness" in TCA type "select"

Closed

2013-10-17

Actions

Related to TYPO3 Core - Bug #47409: Skip sprite in element from suggest-list

Closed

Stefan Neufeind

2013-04-20

Actions

Related to TYPO3 Core - Bug #48474: Suggest Wizard doesn't work properly when inside Flexform repeating elements

Closed

2013-05-23

Actions

Related to TYPO3 Core - Bug #50549: The suggest search does not work in new unsaved content elements.

Closed

2013-07-30

Actions

Related to TYPO3 Core - Bug #59642: Suggest wizard doesn't work in page flexforms

Closed

2014-06-18

Actions

Related to TYPO3 Core - Bug #47413: Suggest wizard doesn't add item to select field if used in flexform

Closed

2013-04-21

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Philipp Wrann over 10 years ago

in jsfunc.tceforms_suggest.js this selector [line 101 on current master]
var suggestLabelNode = Element.select(this.escapeObjectId(item.id), '.suggest-label')[0];

allways returns the first selected item.

just a first hint... i dont have time to read further but maybe it helps.

does not explain the removing behaviour though

Actions

Copy link

Updated by Markus Klein about 10 years ago

Category changed from FormEngine aka TCEforms to Backend User Interface
Status changed from New to Accepted
Target version deleted (~~6.2.0~~)
TYPO3 Version changed from 6.2 to 4.5

Can confirm that for 4.5 too

Actions

Copy link

Updated by Philipp Wrann about 10 years ago

Also 4.7, additionally in 4.7 (4.7.17) it appears also when only 1 suggest wizard is rendered.

Actions

Copy link

Updated by GAYA La Nouvelle Agence almost 10 years ago

File jsfunc.tceforms_suggest.js.patch jsfunc.tceforms_suggest.js.patch added

Also in 6.2.3. I join a patch of jsfunc.tceforms_suggest.js for this version. Please check it cause I'm not expert in prototype library but this works for me.

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513

Actions

Copy link

Updated by Markus Klein almost 10 years ago

Related to #47409

Actions

Copy link

Updated by Rémy DANIEL almost 10 years ago

What is the status of this review? Why `item.id` needs to be escaped with `this.escapeObjectId()`?

Actions

Copy link

Updated by Markus Klein almost 10 years ago

Hi Daniel!

Please post feedback to a patch directly in Gerrit. I just invited you there. Login with your normal TYPO3 account.

The escape is necessary due to [] characters, see https://review.typo3.org/20045

Actions

Copy link

#10

Updated by Rémy DANIEL almost 10 years ago

I fix a JS error in #59655. Maybe this is related to this particular issue, because it fixed it for me...

Actions

Copy link

#11

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513

Actions

Copy link

#12

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513

Actions

Copy link

#13

Updated by Gerrit Code Review almost 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513

Actions

Copy link

#14

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31479

Actions

Copy link

#15

Updated by Anonymous almost 10 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset a026f1873c8ae95a4feed3b7bdf0284076a65bb5.

Actions

Copy link

#16

Updated by Benni Mack over 5 years ago

Status changed from Resolved to Closed

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

TYPO3 Core

Custom queries

Watchers (3)

Bug #55835

Suggest wizard does not work correctly in flexforms

Updated by Philipp Wrann over 10 years ago

Updated by Markus Klein about 10 years ago

Updated by Philipp Wrann about 10 years ago

Updated by GAYA La Nouvelle Agence almost 10 years ago

Updated by Gerrit Code Review almost 10 years ago

Updated by Gerrit Code Review almost 10 years ago

Updated by Markus Klein almost 10 years ago

Updated by Rémy DANIEL almost 10 years ago

Updated by Markus Klein almost 10 years ago

Updated by Rémy DANIEL almost 10 years ago

Updated by Gerrit Code Review almost 10 years ago

Updated by Gerrit Code Review almost 10 years ago

Updated by Gerrit Code Review almost 10 years ago

Updated by Gerrit Code Review almost 10 years ago

Updated by Anonymous almost 10 years ago

Updated by Benni Mack over 5 years ago