Bug #58050
closed
Using gridelements without EXT:workspaces gives SQL-warnings
0%
Description
Gridelements seems to somewhere still create SQL-queries with a workspace-parameter although EXT:worksapces is not loaded (and the DB does not have those extra column). This happened to me in the page-module.
exec_SELECTquery
caller TYPO3\CMS\Core\Database\DatabaseConnection::exec_SELECTquery
ERROR Unknown column 'workspace' in 'where clause'
lastBuiltQuery SELECT * FROM sys_refindex WHERE tablename='tt_content' AND recuid=101 AND workspace=0 ORDER BY sorting
debug_backtrace require(typo3_src-git/typo3/sysext/recordlist/mod1/index.php),typo3_src-git/typo3/mod.php#45 // TYPO3\CMS\Recordlist\RecordList->main#44 // TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRecordList->generateList#345 // GridElementsTeam\Gridelements\Xclass\DatabaseRecordList->getTable#446 // GridElementsTeam\Gridelements\Xclass\DatabaseRecordList->renderListRow#324 // GridElementsTeam\Gridelements\Helper\Helper->getChildren#826 // TYPO3\CMS\Version\Dependency\ElementEntity->getChildren#41 // TYPO3\CMS\Core\Database\DatabaseConnection->exec_SELECTgetRows#225 // TYPO3\CMS\Core\Database\DatabaseConnection->debug#369
Updated by Jo Hasenau over 10 years ago
- Category set to 1363
- Status changed from New to Needs Feedback
- Assignee set to Dirk Hoffmann
- Priority changed from Should have to Must have
Since the XCLASS is still based on TYPO3 6.0.x code, I guess this will be fixed after applying the changes between 6.0 and 6.2
Updated by Stefan Neufeind over 10 years ago
This appeared with the latest git-master. Are there pending changes for 6.2 somewhere, which we might help to review? Nothing open in gerrit at the moment.
Updated by Jo Hasenau over 10 years ago
Actually there are no pending changes, but we have to make a DIFF between the list module in 6.0 and 6.2 and then merge that into the current XCLASS.
Updated by Jo Hasenau over 10 years ago
- Status changed from Needs Feedback to Accepted
Updated by Jo Hasenau over 10 years ago
- Assignee changed from Dirk Hoffmann to Ernesto Baschny
It seems that the problem lies in a core class:
\TYPO3\CMS\Version\Dependency\ElementEntity::getChildren
In line 223 there is:
$where = 'tablename=' . $GLOBALS['TYPO3_DB']->fullQuoteStr($this->table, 'sys_refindex') . ' AND recuid='
. $this->id . ' AND workspace=' . $this->dependency->getWorkspace();
As far as I understood, versioning should be independent from workspaces, so there is a check missing.
I will move this issue to the core tracker for further discussion.
Updated by Jo Hasenau over 10 years ago
- Project changed from 2513 to 624
- Category deleted (
1363)
Updated by Michael Stucki over 10 years ago
- Project changed from 564 to TYPO3 Core
Updated by Gerrit Code Review over 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29710
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29710
Updated by Oliver Hader over 10 years ago
- Status changed from Under Review to Needs Feedback
- Assignee deleted (
Ernesto Baschny) - Priority changed from Must have to Could have
- Is Regression set to No
The field "workspaces" of the table "sys_refindex" is defined in the "core" system extension. Please upgrade SQL schema first before modifying the codes...
Updated by Alexander Opitz about 10 years ago
Hi Stefan,
is this issue solved for you with the hint from Oliver?
Updated by Stefan Neufeind about 10 years ago
- Status changed from Needs Feedback to Rejected
Didn't manage to reproduce it anymore on current master. Thanks for taking a look though.